PHP: foreach loop assign the values of an array to a concatenated string and variable

Question

I want to assign the values of an array to a string with a variable:

    $my_array_values = array("apple", "orange", "cellular", "box");

//my function
function my_function ($my_array_values, $string) {
foreach ($my_array_values as $my_array_value) {
$string_query = $string;
 echo $string_query . "<br>";
}
}

//string to loop the variable inside the foreach
$string_variable = "SELECT login FROM table WHERE login = '" . $my_array_value . "'";
my_function ($my_array_values, $string_variable);

If I echo it, the result is this (not taking the array values of the variable):

    SELECT login FROM table WHERE login = ''
SELECT login FROM table WHERE login = ''
SELECT login FROM table WHERE login = ''
SELECT login FROM table WHERE login = ''

The result should be like this:

    SELECT login FROM table WHERE login = 'apple'
SELECT login FROM table WHERE login = 'orange'
SELECT login FROM table WHERE login = 'cellular'
SELECT login FROM table WHERE login = 'box'

How I can do that? Kind regards

And if the $string_variable is like this?: $string_variable = "SELECT login FROM table WHERE login = '" . $my_array_value . "' AND STATUS = 'Active' AND e_mail IS NOT NULL AND e_mail != '' AND usertype != 'home' AND usertype != 'box'"; — Max
– Max, Commented May 18, 2018 at 17:16

Stephen · Accepted Answer · 2018-05-18 17:14:09Z

1

What is it you are trying to achieve? The MySQL IN function looks for values "IN" a subset or other pool of info.

$query= "SELECT login FROM table WHERE login IN ({implode(',', $my_array_values)})";

Would this be easier than looping over and over?

answered May 18, 2018 at 17:14

Stephen

3902 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Stephen Over a year ago

I think what I mean is, why are you iterating an SQL statement over and over? Also, be mindful of SQL injection from within your array.

Max Over a year ago

Yes I know, the SQL is just a string example concatenated with a variable.

Stephen Over a year ago

Ahh I see. My apologies, the example confused me. In that case, either of the answers below are spot on for what you need :)

alanfcm · Accepted Answer · 2018-05-18 17:05:50Z

0

The correct way is like this:

$my_array_values = array("apple", "orange", "cellular", "box");

//my function
function my_function ($my_array_values, $string) {
  foreach ($my_array_values as $my_array_value) {
    $string_query = $string . $my_array_value . "'";
     echo $string_query . "<br>";
  }
}

//string to loop the variable inside the foreach
$string_variable = "SELECT login FROM table WHERE login = '" ;
my_function ($my_array_values, $string_variable);

answered May 18, 2018 at 17:05

alanfcm

6633 silver badges16 bronze badges

2 Comments

Max Over a year ago

And if the $string_variable is like this?: $string_variable = "SELECT login FROM table WHERE login = '" . $my_array_value . "' AND STATUS = 'Active' AND e_mail IS NOT NULL AND e_mail != '' AND usertype != 'home' AND usertype != 'box'";

alanfcm Over a year ago

You would do it the same way. You can concatenate any way you want. Just remember if you want each value in the array, you have to do it like in my answer.

Dave · Accepted Answer · 2018-05-18 17:12:28Z

0

No need to create extra variables in your function. Simply echo what was passed along with the value extracted from the array that was passed.

$my_array_values = array("apple", "orange", "cellular", "box");

//my function
function my_function ($my_array_values, $string) {

    foreach ($my_array_values as $my_array_value) {
        echo $string . $my_array_value . "'<br>";
    }

}  // end of my_function

//string to loop the variable inside the foreach
$string_variable = "SELECT login FROM table WHERE login = '";
my_function ($my_array_values, $string_variable);

answered May 18, 2018 at 17:12

Dave

5,19717 gold badges34 silver badges45 bronze badges

4 Comments

Max Over a year ago

And if the $string_variable is like this?: $string_variable = "SELECT login FROM table WHERE login = '" . $my_array_value . "' AND STATUS = 'Active' AND e_mail IS NOT NULL AND e_mail != '' AND usertype != 'home' AND usertype != 'box'";

Dave Over a year ago

What if it is @Max? The question was pretty specific and did not include the @my_array_value variable in the middle of the query string. There are a lot of ways to break things with the answers given.

Max Over a year ago

I know @Dave: my specific question is: without breaking the string, how I can loop this variable $my_array_value concatenated inside the string?

Dave Over a year ago

You seem to have changed your question. Perhaps we need to step back a little and figure out exactly what it is you are trying to accomplish.

Collectives™ on Stack Overflow

PHP: foreach loop assign the values of an array to a concatenated string and variable

3 Answers 3

3 Comments

2 Comments

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

3 Comments

2 Comments

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related