Adding "non-standard" value to iterated ArrayList

Question

I'm currently writing a script to retrieve registry entries from a list of remote servers and export to CSV.

I've got this, which works (I'm goign to clean up the error handling later), but the output isn't quite what I want to produce as it doesn't export nicely to CSV.

$DataList = New-Object System.Collections.ArrayList
foreach ($Target in $ImportData) {
    Write-Host "Scanning" $Target.ComputerName ":" -NoNewline
    $RegData = Get-RegValue -ComputerName $($Target.ComputerName) -Hive $RegHive -Key $KeyName
    if (!$RegData) {
        Write-Host "No data found for" $Target.ComputerName
        [void]$DataList.Add([PSCustomObject]@{
            ComputerName = $Target.ComputerName
            Hive ="No Data"
            Key = ""
            Value = ""
            Data = ""
            Type = ""
        })
    } else {
        $DataList.Add($RegData)
        Write-Host "Done"
    }
}
$DataList

The output is as follows:

ComputerName Hive            Key                  Value                     Data
------------ ----            ---                  -----                     ---
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... AssetNumber               987
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... BuildDate                 04/
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... iLODefaultPwd             NA
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... OwnerContactDetails       S G
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... OwnerName                 MS
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... OwnerPhone                643
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... PatchAutoManual           Aut
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... ServerRole                Man
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... ServerType                Vir
SERVER1   LocalMachine    SOFTWARE\CUSTOM\Serv... WarrantyExpires           NA

Value        :
Key          :
Data         :
Hive         : None found
Type         :
ComputerName : SERVER2

SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... buildDate                 15/
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... OperatingSystem           Win
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... OwnerContactDetails       M/S
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... OwnerName                 GM
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... OwnerPhone                131
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... PatchAutoManual           -
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... ServerRole                SNB
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... ServerType                Phy
SERVER3     LocalMachine    SOFTWARE\CUSTOM\Serv... WarrantyExpires           -

I suspect the two object types are different but I don't script much and am having a complete mental block on how to get my custom entry to fit in with the ones retrieved automatically.

What does Get-RegValue do? It's not a standard cmdlet.

arco444
– arco444

2018-05-22 08:29:53 +00:00
Commented May 22, 2018 at 8:29 — arco444
– arco444, Commented May 22, 2018 at 8:29
@arco444 Presumably it's from the RemoteRegistry module.

Ansgar Wiechers
– Ansgar Wiechers

2018-05-22 08:35:55 +00:00
Commented May 22, 2018 at 8:35 — Ansgar Wiechers
– Ansgar Wiechers, Commented May 22, 2018 at 8:35

Ansgar Wiechers · Accepted Answer · 2018-05-22 08:57:54Z

1

Get-RegValue (assuming you're using the cmdlet from the RemoteRegistry module) returns a RegistryValue object while the PSCustomObject type accelerator obviously produces PSCustomObject objects. You can check the types for instance with the Get-Member cmdlet.

You can avoid the issue by piping the list through Select-Object. I also wouldn't use an ArrayList in the first place. Just collect the loop output in a variable.

$DataList = foreach ($Target in $ImportData) {
    $RegData = Get-RegValue ...
    if ($RegData) {
        $RegData
    } else {
        [PSCustomObject]@{
            ComputerName = $Target.ComputerName
            Hive         = 'No Data'
            Key          = ''
            Value        = ''
            Data         = ''
            Type         = ''
        }
    }
}

$DataList |
    Select-Object ComputerName, Hive, Key, Value, Data, Type |
    Export-Csv ...

The Select-Object step turns all input objects into custom objects with the selected properties.

edited May 22, 2018 at 8:57

answered May 22, 2018 at 8:49

Ansgar Wiechers

202k27 gold badges286 silver badges363 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Scepticalist Over a year ago

Many thanks - one of my failings - I was trying to needlessly complicate matters!

Collectives™ on Stack Overflow

Adding "non-standard" value to iterated ArrayList

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related