html/php dropdown not working correctly

Question

<li class="dropdown">
  <a href="signin.php" class="dropbtn">Account</a>
  <div class="dropdown-content">
  <?php
    if(isset($_SESSION['on'])) {
      echo '<a href="logout.php">Log out</a>';
    }
    else if (!isset($_SESSION['on'])) {
      echo '<a href="signin.php">Sign in</a>';
      echo '<a href="signup.php">Sign up</a>';
    }
  ?>
  </div>
</li>

So what this is supposed to do is when ur not signed in u get to see the signin and signup dropdown buttons and not the logout. This part works. But as soon as u log in, in stead of showing the log out button and nothing else, it only shows the sign in and sign up buttons. How do i fix this?

Your else if is totally redundant; just use else. Have you called session_start() before this (or any other) HTML output? — Phil
– Phil, Commented May 24, 2018 at 0:20
on the log in page u start the session. And yes the else if i get why it's redundant. I was trying so many things to try and make it work. Do i need to start the session on every page? i thought when u start session once then u have started it until u logout — Arjen
– Arjen, Commented May 24, 2018 at 0:23
How do you "login"? Does it cause this page to be reloaded? — Phil
– Phil, Commented May 24, 2018 at 0:23
justforkicks.000webhostapp.com/index.php that's the link. I don't know how to explain it because i just started with coding — Arjen
– Arjen, Commented May 24, 2018 at 0:26
I suggest you actually read the documentation ~ "session_start() creates a session or resumes the current one" — Phil
– Phil, Commented May 24, 2018 at 0:27

Jonny · Accepted Answer · 2018-05-24 01:37:29Z

2

session_start needs to be available to start or get a session, this needs to be placed at the beginning of your php on the page. If you are checking isset the else is already the result of what will happen if session is not set, so i removed

else if (!isset($_SESSION['on']))

and replaced it with a simple else.

session_start();
if(isset($_SESSION['on'])) {
  echo '<a href="logout.php">Log out</a>';
} else {
  echo '<a href="signin.php">Sign in</a>';
  echo '<a href="signup.php">Sign up</a>';
}

Remember to go back and use the session_start() on the page where you set the sessions to begin with.

edited May 24, 2018 at 1:37

answered May 24, 2018 at 1:33

Jonny

1,3371 gold badge16 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

html/php dropdown not working correctly

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related