PHP: While loop with fetch array running forever?

Question

I'm trying to display all the records from a database but it's just spamming around 1,000 until it finally reaches 30 second timeout. I've only got 3 records in the database, not sure why it's doing this?

while($news = $engine->fetch_array("SELECT * FROM `cms_news` ORDER BY `id` DESC"))
{
    echo 'lol<br>';
}

"lol" gets printed hundreds of times before finally timing out (execution time exceeded)

Here is the fetch_array function from the $engine class:

final public function fetch_array($sql)
{
    $result = $this->connection->query($sql);
    return $result->fetch_array(MYSQLI_ASSOC);
}

As you would have noticed if you printed something relevant to the retrieved row instead of random nonsense, due to how fetch_array is written (first thing it does is to execute the query) it will always retrieve the same first row until it exceeds its time limit. — fvu
– fvu, Commented May 27, 2018 at 15:10
@fvu How would I got about fixing this? I've tried using fetch_assoc but still the same response. — user5405648
– user5405648, Commented May 27, 2018 at 15:11
Easy, don't execute the query in the fetch_array row if you ever want to be able to retrieve anything else than the first row. — fvu
– fvu, Commented May 27, 2018 at 15:12

Martin · Accepted Answer · 2018-05-27 18:14:39Z

1

A while loop will keep running as long as it's true. You will have to switch up the logic for how you're doing things, or as to what you're trying to achieve.

In your example, the while loop,

while($news = $engine->fetch_array("SELECT * FROM `cms_news` ORDER BY `id` DESC")) {

keeps being true, hence why it keeps running.

answered May 27, 2018 at 18:14

Martin

2,4221 gold badge14 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

PHP: While loop with fetch array running forever?

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related