ArrayList add not working in android

Question

This my code. onooltuud is an ArrayList. I get datas Firebase then add the onooltuud arrayList. But arrayList size 0. Caution incoming data from Firebase. Help me.

 public class OnooltActivity2 extends AppCompatActivity implements View.OnClickListener {
ArrayList<String> onooltuud = new ArrayList<String>();`

@Override
protected void onCreate(Bundle savedInstanceState) {
    super.onCreate(savedInstanceState);
    setContentView(R.layout.onoolt_activity_2);



    save = (Button) findViewById(R.id.save);

    database = FirebaseDatabase.getInstance();
    ref = database.getReference("db").child("davaa").child(String.valueOf(davaaniiNo) + "-iinDavaa");
    Query query = ref.orderByChild("onooltDugaar");

    query.addValueEventListener(new ValueEventListener() {
        @Override
        public void onDataChange(DataSnapshot dataSnapshot) {
            int temp = (int) dataSnapshot.getChildrenCount();
            Log.i("count", String.valueOf(temp));
            for (DataSnapshot snapshot : dataSnapshot.getChildren()) {
                Log.i("snapshot", snapshot.getValue().toString());
                Onoolt onoolt = snapshot.getValue(Onoolt.class);
                onoolts.add(onoolt.getOnooltDugaar());
            }
        }

        @Override
        public void onCancelled(DatabaseError databaseError) {
            Toast.makeText(OnooltActivity2.this, "Датаг уншиж чадсангүй: " + databaseError.getCode(), Toast.LENGTH_SHORT).show();
        }

    });

    Log.i("testSize:", String.valueOf(onoolts.size()));

this my code onoolts add not working

You array is called onooltuud, instead or onoolts.add(onoolt.getOnooltDugaar()); put onooltuud.add(onoolt.getOnooltDugaar()); — Suleyman
– Suleyman, Commented May 27, 2018 at 16:02
@LieForBananas :: Maybe you should add that solution tip as an Answer! I don't thing the OP is able to understand your suggest without a more structured response. — Barns
– Barns, Commented May 27, 2018 at 17:31
@Barns you are right, I'll add it as an answer with more details :) — Suleyman
– Suleyman, Commented May 27, 2018 at 17:37

Barns · Accepted Answer · 2018-05-27 18:04:50Z

1

It says that the size() of your Arraylist object onooltuud is zero (= 0) because you never add anything to it. You declared your ArrayList like that:

ArrayList<String> onooltuud = new ArrayList<String>();

And when you add elements you use a different name:

onoolts.add(onoolt.getOnooltDugaar());

The names do not correspond: onooltuud vs onoolts.

Delete this line:

onoolts.add(onoolt.getOnooltDugaar());

and put this line:

onooltuud.add(onoolt.getOnooltDugaar());

edited May 27, 2018 at 18:04

Barns

4,8393 gold badges19 silver badges31 bronze badges

answered May 27, 2018 at 17:42

Suleyman

2,9832 gold badges22 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Suleyman Over a year ago

@Barns Let's hope so! :)

Collectives™ on Stack Overflow

ArrayList add not working in android

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related