PHP not calling constructor on class?

Question

I have a project that I worked on around a year ago. I've coded various things in it and it was at a time where I was just starting out on the road to learning dependency injection.

Long story short, I've forgotten how to pass a parameter to a constructor. I've tried, although it doesn't seem to do anything. I've tried looking at the existing code for Dice but I can't work it out.

<?php declare(strict_types = 1);

$dice = new \Dice\Dice;

$configRule = [
    "constructParams" => ["config_directory_here"],
];

$dice->addRule("App\Providers\Configuration", $configRule);

The class in question

<?php declare(strict_types = 1);

namespace App\Providers;

class Configuration {
    private $config;

    public function __construct($configDirectory) {
        exit($configDirectory);
        $this->config = array();
        $this->loadConfig($configDirectory);
    }
}

As you can see, in the constructor I have this:

exit($configDirectory);

I don't get anything back, it just continues with the code and prints the Twig template, shouldn't it at least just print an empty string even if it didn't get passed?

I've not sure if this is a problem with my dice code or my PHP itself. I have PS4 autoloading so the Configuration class should be included.

"autoload": {
    "psr-4": {
        "App\\": "src"
    }
}

Can anyone help me here? Thanks! When adding the below code it works as expected, but I need to use a Dependency Injection Container to load the class.

$config = new \App\Providers\Config("test");

Why not echo then exit for making sure? PHP surely passes constructor parameters. Seems you are asking the specific way of doing DI that is preconfigured in a certain framework. — Kita
– Kita, Commented May 31, 2018 at 0:48
"PHP surely passes constructor parameters", if you read the question I'm relying on a DIC, not PHP. Echo and then exiting will do exactly the same, just in case I just tried it and it didn't change the outcome. — user5405648
– user5405648, Commented May 31, 2018 at 0:51
please include the code that initializes Configuration with DIC. — Kita
– Kita, Commented May 31, 2018 at 1:04

Tom B · Accepted Answer · 2018-08-18 13:01:54Z

3

Full disclosure: I'm the author of Dice.

The reason this isn't working is because Dice never prematurely creates an object. The Configuration object won't be created until you request an instance from the container:

$configuration = $dice->create("App\Providers\Configuration");

answered Aug 18, 2018 at 13:01

Tom B

2,9432 gold badges27 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Ralf Gerald · Accepted Answer · 2018-05-31 00:59:17Z

1

The constructor is suppose to create an object and cannot return anything but the object it is attempting to create. You should never create constructors that do any job other then assigning constructor parameters to the object properties.

answered May 31, 2018 at 0:59

Ralf Gerald

585 bronze badges

1 Comment

user5405648 Over a year ago

This makes absolutely no sense. A constructor will exit perfectly fine if I initialize the class myself without DIC which proves the issue is with the DCI, and I'm only exiting for debugging purposes. This is not an answer.

Collectives™ on Stack Overflow

PHP not calling constructor on class?

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related