django is showing validation errors on its own error page

Question

For form validation I need to send error messages, for that I am using validation error but instead of sending errors to template its showing validation error on its error page, you can see image.

In my views

    def form_valid(self, form):
    user = get_current_user(self.request)
    review = self.request.POST.get('review')
    user_profile = get_object_or_404(UserProfileModel, display_username=self.kwargs['display_username'])
    ratings = get_object_or_404(Rating,user_profile_model=user_profile)
    try:
        usr_rating = UserRating.objects.get(rating=ratings, user = user)
    except UserRating.DoesNotExist:
        usr_rating = None
    if usr_rating:
        usr_rating.review = review
        usr_rating.save()
    else:
        raise forms.ValidationError('Please rate first')
    return super(UserProfileView,self).form_valid(form)

In my template

  {% if not form.is_valid %}
      {% for error in form.errors %}
          error
      {% endfor %}
    {% endif %}

I am unable to figure out the problem or I am confused to use form validation, please help me out.

You really shouldn't be doing this validation in form_valid - that is for when the form is already valid. Indeed, you shouldn't do it in the view at all, but in the form itself. — Daniel Roseman
– Daniel Roseman, Commented Jun 14, 2018 at 6:24

neverwalkaloner · Accepted Answer · 2018-06-14 06:11:35Z

1

Django will not handle errors raised on view level as form error. Instead of raise error you need to add form error using add_error method. You can override get_form method for this:

def get_form(self, form_class=None):
    form = super().get_form(form_class)
    if self.request.method == 'POST':
        user = get_current_user(self.request)
        review = self.request.POST.get('review')
        user_profile = get_object_or_404(UserProfileModel, display_username=self.kwargs['display_username'])
        ratings = get_object_or_404(Rating,user_profile_model=user_profile)
        try:
            usr_rating = UserRating.objects.get(rating=ratings, user = user)
        except UserRating.DoesNotExist:
            usr_rating = None
        if usr_rating:
            usr_rating.review = review
            usr_rating.save()
        else:
            form.add_error(None, 'Please rate first')
    return form

This will add non_feild_errors:

{% if form.non_field_errors %}
    {{ form.non_field_errors }}
{% endif %}

edited Jun 14, 2018 at 6:11

answered Jun 14, 2018 at 5:59

neverwalkaloner

47.6k7 gold badges101 silver badges103 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Pankaj Sharma Over a year ago

Thanks sir but its showing me this error - 'ReviewForm' object has no attribute 'cleaned_data'

neverwalkaloner Over a year ago

@PankajSharma try to add request method validation. See updates.

vermanil Over a year ago

You are not triggering the cleaning and validation of the form, this is made by calling the form.is_valid() method, that's why you have no cleaned data.

Pankaj Sharma Over a year ago

ohh, thanks a lot it worked , check if you could help me out in this also stackoverflow.com/questions/50822957/…

Collectives™ on Stack Overflow

django is showing validation errors on its own error page

1 Answer 1

4 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Your Answer

Sign up or log in

Post as a guest

Related