includes method not checking input against array in Javascript

Question

First off, new to Javascript ... trying to write good code! As a test for the app I am writing, I want to have a user's name input via prompt checked against an array that will enable user to keep going or prevent user from doing so.

I can get includes to filter properly when I assign a value to a variable:

var name, excluded_Persons;
var name = "jim"

function denyEntry () {

var excluded_Persons = ["bob", "jim"];

    if (excluded_Persons.includes(name)) {
    alert("You may not enter!!");
    enterName ();
    }

    else {
        allowEntry ();
    }
}
denyEntry ();

function allowEntry () {

    alert("You have been granted access!!");
}

returns "You may not enter!" However, when I include the function enabling the user to input a name,

    var name, excluded_Persons;

function enterName () {
    var name = prompt("What is your name?").toLowerCase();
    }

enterName ();

function denyEntry () {

    var excluded_Persons = ["bob", "jim"];

    if (excluded_Persons.includes(name)) {
    alert("You may not enter!!");
    enterName ();
    }

    else {
        allowEntry ();
    }

}

denyEntry ();

any name the user inputs (including "bob" and "jim") returns "You have been granted access!" The includes function is being bypassed.

Am I missing an argument in either the enterName function or the denyEntry function?

You should stop where you are and consider using a server side solution for this. Dealing with user access client side is way to easy to bypass. — Asons
– Asons, Commented Jun 15, 2018 at 17:38
Remove var in front of the variable name that's inside the enterName function. — devlin carnate
– devlin carnate, Commented Jun 15, 2018 at 17:38
@LGSon, the app I'm working on doesn't actually involve authentication. If it did I totally agree with you. — Daniel McNaughton
– Daniel McNaughton, Commented Jun 15, 2018 at 19:01

amrender singh · Accepted Answer · 2018-06-15 17:41:35Z

1

You are redeclaring the Name inside function enterName() so its scope is limited to only that function. Make name global variable:

var name, excluded_Persons;

function enterName () {
     name = prompt("What is your name?").toLowerCase();
}

enterName ();

function denyEntry () {

    var excluded_Persons = ["bob", "jim"];
    console.log(name);
    if (excluded_Persons.includes(name)) {
    alert("You may not enter!!");
    enterName ();
    }

    else {
        allowEntry ();
    }

}

denyEntry ();

edited Jun 15, 2018 at 17:41

answered Jun 15, 2018 at 17:38

amrender singh

8,2594 gold badges27 silver badges30 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

devlin carnate Over a year ago

The first line declares name as a global. The problem is that there's a local variable of the same name inside the enterName function.

devlin carnate Over a year ago

Closer. You have var name declared twice. Remove the second one.

Collectives™ on Stack Overflow

includes method not checking input against array in Javascript

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related