if else statement not working on integer values

Question

I have the following code:

-- content of sys.argv is 2 and 10 which is assigned to the specified variables. 

wthreshold, cthreshold = sys.argv
def Alerting():
    if PatternCount < wthreshold:
        print
        print LRangeA
        print
        print 'PatternMatch=(' + str(PatternCount) + '),' + 'ExactTimeFrame[' + str(BeginSearchDVar) + ',' + str(EndinSearchDVar) + ']=(Yes)'
        print
        sys.exit(0)
    elif PatternCount >= wthreshold and PatternCount < cthreshold:
        print
        print LRangeA
        print
        print 'PatternMatch=(' + str(PatternCount) + '),' + 'ExactTimeFrame[' + str(BeginSearchDVar) + ',' + str(EndinSearchDVar) + ']=(Yes)'
        print
        sys.exit(1)
    elif PatternCount >= cthreshold:
        print
        print LRangeA
        print
        print 'PatternMatch=(' + str(PatternCount) + '),' + 'ExactTimeFrame[' + str(BeginSearchDVar) + ',' + str(EndinSearchDVar) + ']=(Yes)'
        print
        sys.exit(2)
    else:
        print
        print LRangeA
        print
        print 'PatternMatch=(' + str(PatternCount) + '),' + 'ExactTimeFrame[' + str(BeginSearchDVar) + ',' + str(EndinSearchDVar) + ']=(Yes)'
        print
        sys.exit(3)


LRangeA = """this line 1
another line 2
one more line 3
line 4 
line 5
line 6
line 7
line 8"""
PatternCount = len(LRangeA.split('\n'))
Alerting()

When I run this code, it doesn't seem to be correctly checking the numbers in the if statements. The code always seems to go into the first if statement even though the value of PatternCount is 8.

wthreshold is not a number. It's a string. Convert it to a number with int() — DYZ
– DYZ, Commented Jun 23, 2018 at 17:27
Switch to Python 3, and you'll get TypeError: '<' not supported between instances of 'int' and 'str' instead of weird results. It's been out for nearly seven years. — Mark Tolonen
– Mark Tolonen, Commented Jun 23, 2018 at 18:11

Mureinik · Accepted Answer · 2018-06-23 17:30:27Z

2

wthreshold and cthreshold are strings coming from the command line arguments. If you want to compare them numerically, you need to convert them to numbers:

wthreshold, cthreshold = [int(x) for x in sys.argv]

answered Jun 23, 2018 at 17:30

Mureinik

316k54 gold badges399 silver badges405 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

swenson Over a year ago

scriptname, feature, logfile, daterange, stringA, stringB, wthreshold, cthreshold, option = sys.argv (How would this work if the number of parameters change as is shown here?)

Mureinik Over a year ago

@swenson Just add more variables to the left side of the operation. Alternatively, you could just explicitly extract them from arg. E.g.: someVariable = int(sys.argv[2].

Collectives™ on Stack Overflow

if else statement not working on integer values

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related