php select from where and problem

Question

$name1 = @$_GET['search'] ;
$name = split(" +",$name1);
$query = "select * from table where field1 = '".$name[0]."'
and field2 = '".$name[1]."'
Order By `date` DESC";

I make a easy search like that, but if $name[0] and $name[1] all have data, the query can work, and if $name[1] is empty, the query is failed. how to add a judge that if $name[1] is empty, hidden and field2 = '".$name[1]."', and make the query like

$query = "select * from table where field1 = '".$name[0]."' Order BydateDESC";

possible duplicate of PHP mysql query judge and not echo the repeart part. — Your Common Sense
– Your Common Sense, Commented Feb 24, 2011 at 9:50

Klaus Byskov Pedersen · Accepted Answer · 2011-02-24 09:50:06Z

2

You can do it with an or:

(and field2 = '".$name[1]."' or '".$name[1]."' = '')

answered Feb 24, 2011 at 9:50

Klaus Byskov Pedersen

122k31 gold badges192 silver badges223 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

S L · Accepted Answer · 2011-02-24 09:58:54Z

1

Try this

 if(!empty($name[0]) or !empty($name[1])){
    $sql = "select * from table where ";

    if($name[0]){
       $fld1 = " field1 = '".$name[0]."'";           
    }
    if($name[1]){
       $fld2 = " field2 = '".$name[1]."'";           
    }

    if($fld1 && $fld2)
    {
        $sql .= $fld1 ." and ".$fld2;
    }
    elseif($fld1){
        $sql .= $fld1;
    }
    elseif($fld2){
        $sql .= $fld2;
    }

 }

edited Feb 24, 2011 at 9:58

answered Feb 24, 2011 at 9:53

S L

14.3k18 gold badges81 silver badges119 bronze badges

Comments

azat · Accepted Answer · 2011-02-24 09:53:48Z

1

It will be better if you in your PHP script, do this check like this


$query = "select * from table where field1 = '$name[0]'"
if ($name[1]) $query .= " and field2 = '$name[1]'";
$query .= 'order by date desc';

answered Feb 24, 2011 at 9:53

azat

3,5551 gold badge30 silver badges31 bronze badges

2 Comments

Your Common Sense Over a year ago

what if there will be 3 parts?

azat Over a year ago

I write simple part, if there will be 3 parts I can write some function joinAnd() and use it

VladTheImpaler · Accepted Answer · 2011-02-24 09:52:16Z

0

$name[1]?'query of it exists':'query if it doesn't';

answered Feb 24, 2011 at 9:52

VladTheImpaler

1381 silver badge6 bronze badges

Collectives™ on Stack Overflow

php select from where and problem

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related