PHP echo code not returning '0' if no results

Question

Here is the query:

$query = "SELECT name,deleted,COUNT(message) as message FROM guestbook_message WHERE name='".$name."' AND deleted=1 GROUP BY name";  
$result = mysql_query($query) or die(mysql_error());
$deletedtotal_row = mysql_fetch_array($result);

Here when I use it:

echo "You have had ".($deletedtotal_row['deleted']) ? $deletedtotal_row['deleted'] : '0'." messages deleted";

This errors, doesn't show an syntax error, but doesn't display any results.

But when I use:

echo ".$totaldeleted_row['deleted'].";

It works fine. But if there is no messages deleted for that user, it returns nothing, but I want it to display '0'.

Any ideas where I'm going wrong?

delphist · Accepted Answer · 2011-02-25 14:06:44Z

1

echo "You have had ".intval($deletedtotal_row['deleted'])." messages deleted";

answered Feb 25, 2011 at 14:06

delphist

4,5591 gold badge24 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Lekensteyn Over a year ago

Not sure why someone downvoted this, but we do not have to correct typo's but suggest better code.

xzyfer · Accepted Answer · 2011-02-25 14:06:29Z

0

change this:

echo "You have had ".($deletedtotal_row['deleted'] ? $deletedtotal_row['deleted'] : '0')." messages deleted";

Also, this echo ".$totaldeleted_row['deleted']."; is very bad. Do this instead:

echo $totaldeleted_row['deleted'];

answered Feb 25, 2011 at 14:06

xzyfer

14.2k5 gold badges37 silver badges46 bronze badges

10 Comments

ircmaxell Over a year ago

It's not very bad. It may not be optimal. It may not be great to read. But it's by no means very bad (especially related to your alternative)...

Tom Over a year ago

Thanks for your answer. Is using name=".$name." ok to use in the query?

Tom Over a year ago

It seems to throw all my divs out of sync when I use that. It's fine until I try to display the '0' result. The divs are also inside the php.

xzyfer Over a year ago

@Tom, Depends where $name is coming from. If it's correct sanitized then yes. But you should really be using prepared statements rather than plain old xml. Look at the mysqli or pdo libraries. They're packaged with PHP 5.

xzyfer Over a year ago

@ircmaxell, my alternative is the correct an only syntax that wont return any kind of error/notice/warning. For this to be anywhere near correct usage it would have to be "{$totaldeleted_row['deleted']}". As it is it would output .x. and return a warning or notice I believe.

|

Cory Dee · Accepted Answer · 2011-02-25 14:08:15Z

0

if(mysql_num_rows($result)==0) {
   echo 'no rows';
} else {
   echo "You have had " . $deletedtotal_row['deleted'] ." messages deleted";
}

answered Feb 25, 2011 at 14:08

Cory Dee

2,8977 gold badges40 silver badges55 bronze badges

1 Comment

Cory Dee Over a year ago

You can just set a var and then use that in your echo - but I think using intval() is probably a better solution.

Tom · Accepted Answer · 2011-02-25 14:15:42Z

0

Thanks everybody. I got it working with:

echo "You have had ".($deletedtotal_row['deleted'] ? $deletedtotal_row['deleted'] : '0')." messages deleted";

answered Feb 25, 2011 at 14:15

Tom

4882 gold badges8 silver badges11 bronze badges

1 Comment

xzyfer Over a year ago

If you use someone's answer you should acknowledge it by accepting their answer. It helps your acceptance rating, which inturn makes people more inclined to help you. It's also the foundation of the stack exchange network.

Alex Lomakin · Accepted Answer · 2013-01-22 12:30:24Z

0

use:

sprintf("You have had %d messages deleted", $deletedtotal_row['deleted');

answered Jan 22, 2013 at 12:30

Alex Lomakin

4335 silver badges9 bronze badges

Collectives™ on Stack Overflow

PHP echo code not returning '0' if no results

5 Answers 5

1 Comment

10 Comments

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

1 Comment

10 Comments

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related