PHP function running inside loop not working (with code)

Question

I am running this function

function Age($month, $day, $year) {
    date_default_timezone_set('America/New_York');
    $dob = $month .''. $day .''. $year;
    $startDate = strtotime($dob);
    $endDate = time();
    $dif = $endDate - $startDate;

    return $years = (date('Y', $dif) - 1970) .' y, '. ($months = date('n', $dif) - 1).' m';
}

inside a foreach loop (some CodeIgniter markup):

foreach ($users as $row) {
    echo $this->includes->Age($row->birth_month, $row->birth_day, $row->birth_year)
  }

The loop works OK, showing all my users.

But the problem is that it calculates the age correctly for the first user and then shows that same age for all other users. I should point out that all other user's data is correct, only the age is wrong.

Anyone know how to fix this?

Thanks!

Shad · Accepted Answer · 2011-02-26 21:27:51Z

3

Your $dob looks malformed. Try $dob = $year . '-' . $month . '-' $day;

answered Feb 26, 2011 at 21:27

Shad

15.5k2 gold badges24 silver badges34 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Shad Over a year ago

strtotime() Doesn't like 'mm-dd-yyyy'

user635913 · Accepted Answer · 2011-02-26 21:36:36Z

1

You're missing space/separators.

$dob = $month .''. $day .''. $year;

should be

$dob = $month .'/'. $day .'/'. $year;

edit: Ambiguity. If using mm-dd-yyyy format, should be /

. and - indicate dd-mm-yyyy

edited Feb 26, 2011 at 21:36

answered Feb 26, 2011 at 21:31

user635913

112 bronze badges

1 Comment

azat Over a year ago

This is not necessary, but if so, the best way is use mktime

azat · Accepted Answer · 2011-02-26 21:22:48Z

0

Maybe CI is caching the result?
Seems that function Age is correct

answered Feb 26, 2011 at 21:22

azat

3,5551 gold badge30 silver badges31 bronze badges

3 Comments

pepe Over a year ago

to my eyes CI is running the function (top code) and returning the values straight to the view (bottom code), so I just can't understand why it doesn't refresh the value for each loop

azat Over a year ago

Oh.. try to use this foreach ($users as &$row)

pepe Over a year ago

&$row didn't work - tried @shad's suggestion above and fixed the issue (malformed date var)

Collectives™ on Stack Overflow

PHP function running inside loop not working (with code)

3 Answers 3

1 Comment

1 Comment

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related