Dyanamic Execution of javascript code

Question

I have the following JavaScript:

var djs = function (ob) {

    return {
        remove: function () { //removes element
            if (is_array(ob)) {
                for (var i = 0; i < ob.length; i++) 
                    ob[i].parentNode.removeChild(ob[i]);
            } else {
                ob.parentNode.removeChild(ob);
            }
        },
        empty: function () { //makes element empty
            if (is_array(ob)) {
                for (var i = 0; i < ob.length; i++) 
                    ob[i].innerHTML = "";
            } else {
                ob.innerHTML = ""
            }
        },
        html: function (str) { //gets or sets innerHTML
            if (str) {
                if (is_array(ob)) {
                    for (var i = 0; i < ob.length; i++) 
                       ob[i].innerHTML = str;
                } else {
                    ob.innerHTML = str;
                }
            } else {
                if (is_array(ob)) {
                    for (var i = 0; i < ob.length; i++) 
                        rob += ob[i].innerHTML;
                    return rob;
                } else {
                    return ob.innerHTML;
                }
            }
        }
    }
}

Here every time I am checking whether ob is an array or not and executing code. I want to minimize this, like instead of:

if (is_array(ob)) { 
    for (var i = 0; i < ob.length; i++) 
        ob[i].parentNode.removeChild(ob[i]);
} else { 
    ob.parentNode.removeChild(ob); 
}

I want to use a function like, doEval(ob,code,return), in this case,

doEval(ob,"parentNode.removeChild("+ob+")",NULL);

"return" parameter will return if I specify any like innerHTML. Can any one help?

I think you could do this with a higher-order function, but Javascript also has an eval function. — Brandon Bohrer
– Brandon Bohrer, Commented Feb 27, 2011 at 19:49

Ming-Tang · Accepted Answer · 2011-02-27 19:50:39Z

5

Don't repeat is_array check:

var djs=function(ob) {
  if (!is_array(ob)) ob = [ob];

answered Feb 27, 2011 at 19:50

Ming-Tang

17.7k8 gold badges40 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

johusman · Accepted Answer · 2011-02-27 20:11:55Z

0

@SHiNKiROU is right of course, but just to provide an example of how to solve your problem with higher-order functions:

function doToAll(ob, callback) {
    if(is_array(ob)) {
        for (var i = 0; i < ob.length; i++) {
            callback(ob[i]);
        }
    } else {
        callback(ob);
    }
}

...

remove:function(){ //removes element
    doToAll(ob, function(actualOb) { actualOb.parentNode.removeChild(actualOb); });
},
...

But again, use @SHiNKiROU:s answer for this particular case.

answered Feb 27, 2011 at 20:11

johusman

3,4721 gold badge19 silver badges11 bronze badges

Comments

pimvdb · Accepted Answer · 2011-02-27 19:48:29Z

-1

Try this:

function doEval(a, b, c) {
    if(is_array(a)) {
        eval(b);
    } else {
        eval(c);
    }
}

NULL doesn't exist by the way, it is null.

answered Feb 27, 2011 at 19:48

community wiki

pimvdb

Collectives™ on Stack Overflow

Dyanamic Execution of javascript code

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related