Changing for loop to use forEach in javascript

Question

For my project, I have a list of students and am meant to use super basic regular expressions to check their grades. The A and B students are to be added to separate arrays for only those students. The code for doing so is as follows:

const aTest = new RegExp(/(A)/i);
const bTest =  new RegExp(/(B)/i);
const aStudents = [];
const bStudents = [];
for (var i = 0; i < students.length; i++) {
  if (aTest.test(students[i].grade)) {
    aStudents.push(students[i]);
  }
  if (bTest.test(students[i].grade)) {
    bStudents.push(students[i]);
  }
}

However, if I were to use forEach instead of a for loop, how should I go about doing so?

CertainPerformance · Accepted Answer · 2018-07-25 00:56:58Z

2

You just need to change every students[i] to the first parameter provided to the forEach (which references the current item being iterated over in the array), probably call it student:

students.forEach(student => {
  if (aTest.test(student.grade)) {
    aStudents.push(student);
  } else if (bTest.test(student.grade)) {
    bStudents.push(student);
  }
});

But if you have a regular expression literal already, there's no need for new RegExp - just assign the regular expression literal to the variable. Also, there's no need for a captured group if you just need to test:

const aTest = /A/i;
const bTest = /B/i;

Or, you might avoid regular expressions entirely and use (ES6) .includes instead:

  if (student.grade.includes('A')) {
    aStudents.push(student);
  } else if (student.grade.includes('B')) {
    bStudents.push(student);
  }

answered Jul 25, 2018 at 0:56

CertainPerformance

373k55 gold badges354 silver badges359 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

webNeat · Accepted Answer · 2018-07-25 01:08:37Z

1

I would use filter instead of forEach, yes it loops over the array twice but the code is clearer to read and understand

const aStudents = students.filter(student => student.grade.match(/A/i));
const bStudents = students.filter(student => student.grade.match(/B/i));

answered Jul 25, 2018 at 1:08

webNeat

2,8661 gold badge22 silver badges25 bronze badges

Collectives™ on Stack Overflow

Changing for loop to use forEach in javascript

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related