Javascript - onclick function change boolean value and change attr visibility

Question

So I'm learning Javascript and I have a doubt on changing a global variable with boolean variable, while changing the attr of visibility on an element.

The code is this:

var lastView=false;

$("#idShipmentActionsCombo-icon").on('click', function(){

if (lastview=false){

$('#idShipmentActionsCombo-lb').attr('style', 'visibility: visible');
    lastView=true;

}

else if(lastView=true){

$('#idShipmentActionsCombo-lb').attr('style', 'visibility: hidden');
    lastView===false;

    }
}

So #idShipmentActionsCombo-icon is the element I click in, #idShipmentActionsCombo-lb and this is what I want to show and hide depending on the value of lastView.

Thanks in advance, and I apologize for my English since it's not my main language.

Kosh · Accepted Answer · 2018-08-04 15:05:21Z

1

Since you use jQuery use .toggle() method instead of booleans, conditions and style.

$("#idShipmentActionsCombo-icon").on('click', function(){ 
   $('#idShipmentActionsCombo-lb').toggle();
})

edited Aug 4, 2018 at 15:05

answered Aug 3, 2018 at 20:46

Kosh

18.6k2 gold badges24 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Autumn Leonard · Accepted Answer · 2018-08-03 20:53:54Z

0

Looks like you're missing a closing ); at the very end from your .on( In addition, there are a few cases where "===" and "=" are confused and where capitalization is incorrect. See this: http://jsfiddle.net/215sxj90/3/

edited Aug 3, 2018 at 20:53

answered Aug 3, 2018 at 20:48

Autumn Leonard

5088 silver badges23 bronze badges

Comments

ischenkodv · Accepted Answer · 2018-08-03 21:13:01Z

0

In my opinion you're confusing assignment with logical operators. The following is the assignment:

lastView = true;

and the following is the logical operator - comparison:

lastView === true

The latter should be used in your conditional statements - if, else if etc.:

var lastView = false;

$("#idShipmentActionsCombo-icon").on('click', function () {

    if (lastview === false) {

        $('#idShipmentActionsCombo-lb').attr('style', 'visibility: visible');
        lastView = true;

    }
    else if (lastView === true) {
        $('#idShipmentActionsCombo-lb').attr('style', 'visibility: hidden');
        lastView = false;

    }
}

answered Aug 3, 2018 at 21:13

ischenkodv

4,2652 gold badges29 silver badges38 bronze badges

Collectives™ on Stack Overflow

Javascript - onclick function change boolean value and change attr visibility

3 Answers 3

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related