Modifying Javascript to run after AJAX load

Question

I am using a little javascript thingy (app?) from http://code.google.com/p/tumblrbadge/ to load my most recent tumblog post into my webpage. However, when I load the 'tumblr' section with AJAX using Jquery, the script does not get executed. I understand why this is and that I need to include the javascript file in the and execute it after the AJAX load is complete. My problem is this: I do not fully understand the tumblrbadge code and, when I include the script in the and call tumblrBadge() after loading, it does not run. How must I modify the tumblrbadge code to allow it to be run on demand from the ?

All of this is hosted at http://jquerytest.webs.com

Well, doesn't $(document).ready() is for exactly that (which is already done in .js file)? — Arda
– Arda, Commented Mar 3, 2011 at 2:25
I'm facing similar situation where $(document).ready() is not really working under Safari, but works fine with other browsers. So I'm curious to know the answer to this question. — DJ.
– DJ., Commented Mar 3, 2011 at 2:32
I wasn't using a ready function at all. Would that work without eval() if the code was loaded with AJAX? — Scott Colby
– Scott Colby, Commented Mar 3, 2011 at 2:33
Can you review your question and add more detail. What does the ? refer to and in what are you including when you say "I include the script in the and call..."? — jordancpaul
– jordancpaul, Commented Mar 3, 2011 at 9:36

Rob W · Accepted Answer · 2011-11-28 22:19:40Z

1

It looks like your problem is that the script tags within the tumblr section of your site are not being executed. When you insert html into a page using ajax, you have to parse out the contents of any script tags and execute them separately.

After the content of the tumblr tab is inserted in your page, get all of its script tags with $("#contentOfTumblrTab script") and evaluate their innerHTML using eval().

edited Nov 28, 2011 at 22:19

Rob W

350k87 gold badges811 silver badges683 bronze badges

answered Mar 5, 2011 at 4:40

tilleryj

14.4k3 gold badges26 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Scott Colby Over a year ago

That is exactly my problem. Is there any problem with using eval this way? I have seen all over that it is "bad."

tilleryj Over a year ago

Using eval is a code smell in javascript because it usually means you don't know the "right" way to do something and it also can be unsafe in some situations to eval a string. In this case, however, it's ok. You can also take a look at jslint (jslint.com/lint.html) if you want to see how your code holds up against some javascript best practices.

Ryre · Accepted Answer · 2011-11-28 22:24:36Z

0

Try $(window).onload instead of $(document).ready.

answered Nov 28, 2011 at 22:24

Ryre

6,1895 gold badges33 silver badges47 bronze badges

Collectives™ on Stack Overflow

Modifying Javascript to run after AJAX load

2 Answers 2

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related