Laravel SQL Query Returning Duplicates

Question

I am trying to increase the speed of my Laravel 5.4 sql query by using joins, which I've never used before. I currently have the query working and returning results, my issue is that I get like each results around 8 times. Ex: I get the same 2001 Chevrolet Silverado 8 times in my array. If anybody could help me out I would really appreciate it. Thanks

My query + collection:

$tmp = DB::table('inventories'
            )->join(
                'vehicles', 'vehicles.id', '=', 'inventories.id'
            )->join(
                'vimages', 'vimages.vehicle_id', '=', 'inventories.id'
            )->where(
                'inventories.dealer_id', '=', $dealer_id
            )->where(
                'inventories.is_active', '=', 1
            )->where(
                'inventories.is_deleted','=', 0
            )->select(
                'inventories.stock_number','inventories.vehicle_id','vehicles.year','vehicles.make','vehicles.model','vehicles.vin','inventories.vehicle_status',
                'inventories.cost','inventories.search_meta','vimages.name'
        );


        $data = collect();
        $pmt = $tmp->get();
        // return json_encode( $pmt );

        // logger( sprintf('# of rows returned: %s', $pmt->count() ) );

        $pmt->each( function($row) use(&$data) {
          // logger( sprintf('Row    : %s', $row->toJson() ));

            $data->push( array(
                'stock_number' => $row->stock_number,
                'vehicle_id' => $row->vehicle_id,
                'year' => $row->year,
                'make' => $row->make,
                'model' => $row->model,
                // 'trim' => $row->trim,
                'vin' => $row->vin,
                'status' => $row->vehicle_status,
                // 'purchase_price' => $row->purchase_price,
                'cost' => $row->cost,
                // 'retail_price' => $row->retail_price,
                'search_meta' => $row->search_meta,
                // 'images' => $row->getFirstImage()
                'images' => $row->name
                // 'interior_color' => $row->vehicle()->first()->interior_color,
                // 'exterior_color' => $row->vehicle()->first()->exterior_color,
                // 'firstImg' => $row->getFirstImage()
                // 'images' => Vimage::select('vehicle_id','name'
                //                 )->where(
                //                     'dealer_id', '=', $row->dealer_id
                //                 )->where(
                //                     'vehicle_id', '=', $row->vehicle_id
                //                 )->limit(1)->get()
            ));

        });

Example of my array: https://i.sstatic.net/gq7w0.png

Do you have multiple images?

Devon Bessemer
– Devon Bessemer

2018-08-13 13:02:29 +00:00
Commented Aug 13, 2018 at 13:02 — Devon Bessemer
– Devon Bessemer, Commented Aug 13, 2018 at 13:02

Udit Solanki · Accepted Answer · 2018-08-13 13:21:55Z

2

I don't see your db table but I think there is problem in first join statment: you should use

->join('vehicles', 'vehicles.id', '=', 'inventories.vehicle_id' )

instead of

->join('vehicles', 'vehicles.id', '=', 'inventories.id' )

also second join should be like

->join('vimages', 'vimages.vehicle_id', '=', 'vehicles.id')

instead of

->join('vimages', 'vimages.vehicle_id', '=', 'inventories.id')

edited Aug 13, 2018 at 13:21

Udit Solanki

5315 silver badges12 bronze badges

answered Aug 13, 2018 at 13:14

Mina Zakaria

1039 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Justin Kruskie Over a year ago

Thank you. The inventories table doesn't contain a vehicle_id though. The id of inventories correlates with the vehicle_id of the vehicles table.

Dimitri Mostrey · Accepted Answer · 2018-08-13 13:30:30Z

1

It sounds trivial but this should work:

$tmp = DB::table('inventories'
        )->join(
            'vehicles', 'vehicles.id', '=', 'inventories.id'
        )->join(
            'vimages', 'vimages.vehicle_id', '=', 'inventories.id'
        )->where(
            'inventories.dealer_id', '=', $dealer_id
        )->where(
            'inventories.is_active', '=', 1
        )->where(
            'inventories.is_deleted','=', 0
        )->selectRaw("DISTINCT inventories.stock_number, inventories.vehicle_id, 
            vehicles.year, vehicles.make, vehicles.model, vehicles.vin, 
            inventories.vehicle_status, inventories.cost, 
            inventories.search_meta, vimages.name"
    );

Update: forgot to delete the single quotes in selectRaw

edited Aug 13, 2018 at 13:30

answered Aug 13, 2018 at 13:22

Dimitri Mostrey

2,3551 gold badge14 silver badges12 bronze badges

1 Comment

Justin Kruskie Over a year ago

Thank you, I managed to solve it using this though. I posted my answer above.

Justin Kruskie · Accepted Answer · 2018-08-13 13:14:47Z

0

Figured it thanks to @Devon. Added another where statement to query to only get first image.

Thanks

)->where('vimages.sequence','=', 0

answered Aug 13, 2018 at 13:14

Justin Kruskie

4224 silver badges16 bronze badges

Collectives™ on Stack Overflow

Laravel SQL Query Returning Duplicates

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related