PHP Javascript opener.document question

Question

Im trying to pass some values into a text box from a child page to the parent page. The code I have works fine passing one integer value through to the parent page, however it won't pass a string. I also want to try and pass another value through to an additional text box, how would I go about doing that?

logRequestAdmin is the name of the form on the parent page, and ClientName is the text box to post the first value to.

Here's my code for the child page:

<head>
<script type="text/javascript">
    <!-- Begin
    function moveData(info) {
    window.opener.document.logRequestAdmin.ClientName.value = info;
    self.close();
    return false;
    }
    // End -->
</script>

        <table>
            <tr>
                <td class="clientTop">Client ID</td>


                <td class="clientTop">Client Name</td>

                <td class="clientTop">Username</td>

                <td class="clientTop">Email</td>

            </tr>


            $query = "Select * from clients"; 

            $result = mysql_query($query) or die ("Error in query: $query. ".mysql_error());  

            while($row = mysql_fetch_array($result))
            {

                $ClientID = $row['ClientID'];

                $ClientName = $row['ClientName'];

                $Username = $row['Username'];

                $Email = $row['Email'];

                echo '<tr>
                        <td class="clientBottom"><a href="javascript:void();" onclick="moveData(' . $ClientID . ');">' . $ClientID . '</a></td>
                        <td class="clientBottom"><a href="javascript:void();" onclick="moveData(' . $ClientID . ');">' . $ClientName . '</a></td>
                        <td class="clientBottom"><a href="javascript:void();" onclick="moveData(' . $ClientID . ');">' . $Username . '</a></td>
                        <td class="clientBottom"><a href="javascript:void();" onclick="moveData(' . $ClientID . ');">' . $Email . '</a></td>
                      </tr>';       
            }
        </table>

Ive just removed them from the post to try and clean the code up a little bit — Matt
– Matt, Commented Mar 3, 2011 at 16:24

Farray · Accepted Answer · 2011-03-03 17:27:06Z

It looks like the problem is in your javascript function call in the A tags. Here is how your code works if you pass integers and strings...

echo '...
          <td class="clientBottom"><a href="javascript:void();" onclick="moveData(' . $ClientID . ');">' . $ClientID . '</a></td>
          <td class="clientBottom"><a href="javascript:void();" onclick="moveData(' . $ClientName . ');">' . $ClientName . '</a></td>
      ...';

The above lines write HTML like:

<td class="clientBottom"><a href="javascript:void();" onclick="moveData(1);">1</a></td>
<td class="clientBottom"><a href="javascript:void();" onclick="moveData(The Dude);">The Dude</a></td>

JavaScript thinks you're passing a 1 the first time, and should throw an error on The Dude since the function call is malformed.

If you add some extra apostrophes, it should work just fine.

PHP:

echo '...
          <td class="clientBottom"><a href="javascript:moveData(\'' . $ClientID . '\');">' . $ClientID . '</a></td>
          <td class="clientBottom"><a href="javascript:moveData(\'' . $ClientName . '\');">' . $ClientName . '</a></td>
      ...';

HTML:

<td class="clientBottom"><a href="javascript:moveData('1');">1</a></td>
<td class="clientBottom"><a href="javascript:moveData('The Dude');">The Dude</a></td>

If you want your rows to look cleaner, you could also alter your js function to pass the innerHTML property of the link tag...

<script type="text/javascript">
    function moveData(el) {
        info = el.innerHTML;
        // do something with info...
    }
</script>
...
<a href="javascript:void();" onclick="moveData(this);">Lorem Ipsum</a>

Collectives™ on Stack Overflow

PHP Javascript opener.document question

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related