sorting with bubble sort using 2 function

Question

At first i used bubble sort to sort some numbers.It worked.And then again i tried to sort using bubble sort with 2 function with same logic.but it is not working.I am new to work with 2/3 function.So can anyone help me to find the problem in my logic?

First source

#include<stdio.h>
main()
{
    int i,j;
    float num[5], c;

    for(i=0;i<5;i++)
    {
        scanf("%f",&num[i]);
    }
    for(j=0;j<4;j++)
    {
        for(i=0;i<5;i++)
        {
            if(num[i]<num[i+1])
            {
                c=num[i];
                num[i]=num[i+1];
                num[i+1]=c;
            }
        }
    }
    for(i=0;i<5;i++)
    {
        printf("%.2f\n",num[i]);
    }
}

Second source w/function

#include<stdio.h>
void sort(int a[]);
void main()
{
    int i;
    double a[3], A, B, C;

    for(i=0;i<3;i++)
    {
        scanf("%lf",&a[i]);
    }

    sort(a);

    printf("In The Function\n");
    for(i=0;i<3;i++)
    {
        printf("%.2lf\n",a[i]);
    }

    return;
}

void sort(int a[])
{
    int i, n;
    double temp;

    for(n=0;n<2;n++)
    {
        for(i=0;i<3;i++)
        {
            if(a[i]<a[i+1])
            {
                temp = a[i];
                a[i] = a[i+1];
                a[i+1] = temp;
            }
        }
    }
    return;
}

Please NO external links for code. Paste it here as text and mark it as code. — Sir Rufo
– Sir Rufo, Commented Aug 18, 2018 at 7:22
Questions seeking debugging help ("why isn't this code working?") must include the desired behavior, a specific problem or error and the shortest code necessary to reproduce it in the question itself. Questions without a clear problem statement are not useful to other readers. See: minimal reproducible example — Yunnosch
– Yunnosch, Commented Aug 18, 2018 at 7:37
... find the problem in my logic? Check your array indexes, they could be out of bounds. — wildplasser
– wildplasser, Commented Aug 18, 2018 at 7:44
Please read & act on hits googing 'stackexchange homework'. Show that your program calculates what you expect it to as it goes through (sub)expressions--including that arguments passed to each function/opertaor meet its requirements--by saying what that is & showing what it actually does via output. — philipxy
– philipxy, Commented Aug 18, 2018 at 7:51
Beyond the data type problem that kiran points out below, both source lists suffer from invoking undefined behavior by accessing their array boundaries beyond their declared dimensions. You probably want to fix that too. — WhozCraig
– WhozCraig, Commented Aug 18, 2018 at 7:54

kiran Biradar · Accepted Answer · 2018-08-18 07:51:13Z

1

Do not ignore the warnings.

warning: passing argument 1 of ‘sort’ from incompatible pointer type [enabled by default]
     sort(a);
     ^
sort.c:2:6: note: expected ‘int *’ but argument is of type ‘double *’
 void sort(int a[]);
  ^

You have declared a as double but your function receives a as int. Change it to as below.

void sort(double a[]);

answered Aug 18, 2018 at 7:51

kiran Biradar

12.8k3 gold badges21 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

mahin hossen Over a year ago

sorry i just started working with c.and haven't learnt yet pointer much.so ignored it

WhozCraig Over a year ago

@mahinhossen Compiler warnings are nearly always a sign you're doing something wrong, even for seasoned professional. For a beginner working on the tasks beginners work on, you can be assured warnings are a guarantee you're doing something wrong, and should be treated as errors. Don't ignore them; discover what they mean and fix them.

mahin hossen Over a year ago

thanks i found it.i didn't used a as double,that was the mistake.thanks #kiran biradar

WhozCraig Over a year ago

@mahinhossen That isn't the only mistake. Your indexing is wrong as well. your inner loops are breaching the declared boundaries of your array.

Mohit Kumar Raj Badi · Accepted Answer · 2018-08-18 08:25:26Z

0

You are passing the double

double a;
sort(a);

value in the main function but at the function declaration part your datatype is integer

void sort(int a[])

correct this to

void sort(double a[])

answered Aug 18, 2018 at 8:25

Mohit Kumar Raj Badi

142 bronze badges

Collectives™ on Stack Overflow

sorting with bubble sort using 2 function

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related