Do While Loop: Loop without do error

Question

The below code is providing a "Loop without do error" while I have my very simple do while statement. Code runs without it, however will not loop through the 100 rows I am extracting data from.

Its clear that the issue is a result of the readystate dowhile (as code will run if I comment this out), but I am not sure of the mechanics of this working without this for IE.

Is anyone able to explain what additional(?) line of code I need to add to stop this error?

Do While i < 100

    Set ie = CreateObject("InternetExplorer.Application")

    With ie
        .Navigate URLStart
        .Visible = True
        Do While .ReadyState <> 4: DoEvents: Loop

        Set doc = ie.Document

        With doc
            LicenceNO = "whatever"
            ActiveSheet.Range("C" & i).Value = LicenceNO
            LicenceName = "whatever"
            ActiveSheet.Range("D" & i).Value = LicenceName
            BusinessAddress = "whatever"
            ActiveSheet.Range("E" & i).Value = BusinessAddress
            AATOCategory = "whatever"
            ActiveSheet.Range("F" & i).Value = AATOCategory
        End With

        i = i + 1

Loop

Thanks all!

This is a good example of how uniform indentation and spacing helps highlight coding mistakes. (I fixed the indentation and now it's easier to see the issue.) [I didn't see the answer when I wrote this, but @Olly was on it already!] — ashleedawg
– ashleedawg, Commented Aug 21, 2018 at 10:56
unrelated, note that your loop will run until 99, not until 100. If you need to go to 100 then use <= instead of < — ashleedawg
– ashleedawg, Commented Aug 21, 2018 at 10:58
Right you all are, I had my end with outside my loop. I moved it back inside the loop and its now working fine! — Realitybites
– Realitybites, Commented Aug 21, 2018 at 11:08

Olly · Accepted Answer · 2018-08-21 10:46:38Z

1

With consistent indenting, you can see the missing End With:

Do While i < 100

    Set ie = CreateObject("InternetExplorer.Application")

    With ie
        .Navigate URLStart
        .Visible = True
        Do While .ReadyState <> 4
            DoEvents
        Loop

        Set doc = ie.Document

        With doc
            LicenceNO = "whatever"
            ActiveSheet.Range("C" & i).Value = LicenceNO
            LicenceName = "whatever"
            ActiveSheet.Range("D" & i).Value = LicenceName
            BusinessAddress = "whatever"
            ActiveSheet.Range("E" & i).Value = BusinessAddress
            AATOCategory = "whatever"
            ActiveSheet.Range("F" & i).Value = AATOCategory
        End With

        i = i + 1

    'This line missing:
    End With

Loop

answered Aug 21, 2018 at 10:46

Olly

7,9021 gold badge23 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Do While Loop: Loop without do error

1 Answer 1

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Your Answer

Sign up or log in

Post as a guest

Related