Values of array changing without modification, using foreach loop

Question

I have a sample code. Its strange! Even not making any changes in defined array but still my defined array's value got changed.

$myarr = array(1, 2, 3, 4);
foreach ($myarr as &$myvalue) {
    $myvalue = $myvalue * 2;
}
print_r($myarr); // Output - Array ( [0] => 2 [1] => 4 [2] => 6 [3] => 8 )

Can you please explain, How it happen?

Read about references. Using them in a loop produces unexpected results. This is explained in the documentation: php.net/manual/en/language.references.whatdo.php — axiac
– axiac, Commented Sep 9, 2018 at 10:07
What do you mean? You are multiplying each value in your array by 2, in the foreach statement: $myvalue = $myvalue * 2; The output is correct. — Bandreid
– Bandreid, Commented Sep 9, 2018 at 10:08

dWinder · Accepted Answer · 2018-09-09 10:10:02Z

2

You do change the original array because you are using & in your array loop.

This signal for references as @axiac comments.

In order to avoid changes on your original array use the following for loop:

foreach ($myarr as $myvalue)

answered Sep 9, 2018 at 10:10

dWinder

11.7k3 gold badges27 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

sandeep soni Over a year ago

Thanks David, I could understand that what exactly mean of reference.

Vaibhav Shettar · Accepted Answer · 2018-09-09 10:13:12Z

0

you are passing address of myarr, where myvalue uses same address of myarr that why its changing

use this

  $myarr = array(1, 2, 3, 4);
    foreach ($myarr as $myvalue) {
        $myvalue = $myvalue * 2;
    }
    print_r($myarr);

answered Sep 9, 2018 at 10:13

Vaibhav Shettar

8202 gold badges10 silver badges21 bronze badges

Comments

Alexander Voss · Accepted Answer · 2018-09-09 10:13:31Z

0

have you tried it without the "&" before $myvalue?

Please read here PHP: What does a & in front of a variable name mean?

answered Sep 9, 2018 at 10:13

Alexander Voss

574 bronze badges

Collectives™ on Stack Overflow

Values of array changing without modification, using foreach loop

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related