Powershell creating bulk users with a script

Question

I need to create a lot of users so I wanted to use this script, I created it by myself. The script completed, but if I look in my ADUC there are no new users, what is wrong with my script?

Import-Module ActiveDirectory
$ADusers = Import-csv C:\TEST\Create.CSV

Foreach ($user in $ADusers)
{

    $username   = $user.username
    $password   = $User.password
    $firstname  = $user.firstname
    $Lastname   = $user.lastname
    $OU         = $user.ou

    {
        New-ADUser
        -SamaccountName $username '
        -Name "$firstname $lastname" 
        -ChangePasswordatlogon $True '
        -Givenname $firstname '
        -Surename $lastname '
        -path $OU 
   }
}

henrycarteruk · Accepted Answer · 2018-09-10 10:26:25Z

1

In your code New-ADUser is running without any parameters.

When splitting a command over multiple lines, you need to use a backtick at the end of each line to signify the command continues on the next line.

If you don't do this, the preceding lines aren't linked to the line above.

Import-Module ActiveDirectory
$ADusers = Import-csv C:\TEST\Create.CSV

Foreach ($user in $ADusers)
{
    $username   = $user.username
    $password   = $User.password
    $firstname  = $user.firstname
    $Lastname   = $user.lastname
    $OU         = $user.ou

    New-ADUser `
        -SamaccountName $username `
        -Name "$firstname $lastname" `
        -ChangePasswordatlogon $True `
        -Givenname $firstname `
        -Surename $lastname `
        -path $OU
}

Note: The indenting isn't required in PS, but makes it easier to read and understand the lines are linked to the Command above.

edited Sep 10, 2018 at 10:26

answered Sep 10, 2018 at 9:47

henrycarteruk

13.3k2 gold badges40 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Remco Over a year ago

It's still not working... sorry i'm pretty new with powershell Foreach ($user in $ADusers) { $username = $user.username $password = $User.password $firstname = $user.firstname $Lastname = $user.lastname $OU = $user.ou } { New-ADUser -SamaccountName $username -Name "$firstname $lastname" -ChangePasswordatlogon $True -Givenname $firstname -Surename $lastname -path $OU }

Kirill Pashkov Over a year ago

@Remco, looks like you have placed brackets "{" to the wrong place. So you now have New-ADUser running out of the foreach loop.

henrycarteruk Over a year ago

Updated answer to make it clearer - you don't need the second set of { }, the backticks are instead of these.

Collectives™ on Stack Overflow

Powershell creating bulk users with a script

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related