Laravel array shows as null before data array

Question

I have a user that has many properties. This is user should also be able tp view the offers bet on his properties.

So have the relationship set.

User.php

public function properties(){
    return $this->hasMany('App\Property');
}

Property.php

public function offers(){
    return $this->hasMany('App\Offer');
}

Then in my controller this is what I have:

public function my_offers(){

    $properties = Property::whereUserId(Auth::id())->get();


    return view('pages.seller.offers.index', compact('properties'));
}

Then I go to my views like this:

@if($properties)
<ul>
    @foreach($properties as $property)

        <li>{{$property->offers->offer_message}}</li>

    @endforeach
</ul>
@endif

When I view the page I see the below error:

Property [offer_message] does not exist on this collection instance.

But this property exists in my table.

If I change my list item to the one below I can see the array:

 <li>{{$property->offers}}</li>

I also see that before and after the array with the data, there are two empty arrays as the image shows below:

Is there anything that I didn't correctly?

Well, it seems that not all the properties have offers. Is that something you would expect? — azeós
– azeós, Commented Sep 16, 2018 at 23:21

azeós · Accepted Answer · 2018-09-17 01:49:18Z

1

If not all the properties have offers, then you should check that before the <li>, besides that, offers is a collection, you need to loop through it, that's why you get the error.

@if($properties)
@php ($i = 1)
<ul>
    @foreach($properties as $property)
        @if ($property->offers)
            @foreach ($property->offers as $offer)
                <li>Offer {{ $i++ }}: {{$offer->offer_message}}</li>
            @endforeach
        @endif
    @endforeach
</ul>
@endif

If you want to get only de properties that have offers (Querying Relationship Existence):

$properties = Property::whereUserId(Auth::id())->has('offers')->get();

And you should probably eager load that relationship:

$properties = Property::whereUserId(Auth::id())->has('offers')->with('offers')->get();

edited Sep 17, 2018 at 1:49

answered Sep 16, 2018 at 23:31

azeós

4,9014 gold badges23 silver badges44 bronze badges

Sign up to request clarification or add additional context in comments.

5 Comments

azeós Over a year ago

See my edit. "Offers" is a collection, you need to loop through it.

Sidney Sousa Over a year ago

Giiz. I am definetely taking note for this. It works now and I really appreciate the support

Sidney Sousa Over a year ago

Just in addition to that. How can I number them. Say if I have 3 offers, then system should say "Offer 1", "Offer 2" and so on

azeós Over a year ago

Glad I could help. If you keep the has('offers'), then you could remove the if ($property->offers). You need to number them within each property? I mean, when you loop through a new property, the count should start from 1 again or not? This could help you: laravel.com/docs/5.5/blade#the-loop-variable

Sidney Sousa Over a year ago

Yes I do need to number them accordingly

Collectives™ on Stack Overflow

Laravel array shows as null before data array

1 Answer 1

5 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

5 Comments

Your Answer

Sign up or log in

Post as a guest

Related