Create PHP Variables dynamically in foreach loop

Question

I am just trying to create PHP variables dynamically. below is the code I have tried.

    if($BrickTerritorys)
    {
            foreach($BrickTerritorys as $index=>$BrickTerritory)
            {
                ${"$T.$index"}= $BrickTerritory->TerritoryID;
                ${"'Weightage'.$index"} = $BrickTerritory->Weightage;
            }
            echo $T1."-".$T2."--".$Weightage1."---".$Weightage2; exit;
    }

while 
$BrickTerritorys is 
 [1] => stdClass Object
        (
            [id] => 119
            [TerritoryID] => HYD-2-CMD
            [BrickCode] => 16
            [BrickName] => BUHURO
            [Weightage] => 40.00
            [BPCode] => bp00066
            [GroupCode] => CMD
        )
    [2] => stdClass Object
        (
            [id] => 36330
            [TerritoryID] => HYD-1-CMD
            [BrickCode] => 16
            [BrickName] => BUHURO
            [Weightage] => 60.00
            [BPCode] => bp00066
            [GroupCode] => CMD
        )

When I print in the last, nothing gets printed. Any help is much appreciated, please.

Thanks in advance

Using variable variables is usually an indication of inappropriate array data storage. You are adding unnecessary convolution to your code. — mickmackusa
– mickmackusa ♦, Commented Sep 18, 2018 at 6:33
["'T'.1"]=> string(9) "HYD-2-CMD" ["'Weightage'.1"]=> string(5) "40.00" ["'T'.2"]=> string(9) "HYD-1-CMD" ["'Weightage'.2"]=> string(5) "60.00" result of Global variable... but still i didnt get my desired results..any help ?? — Salman
– Salman, Commented Sep 18, 2018 at 6:37
You are performing dynamic variable generation via a loop, but then hardcoding (expecting) just two values from two rows. Do you actually need variable variables? — mickmackusa
– mickmackusa ♦, Commented Sep 18, 2018 at 6:44
@Salman do you realize that you have granted the green tick to an incorrect answer? — mickmackusa
– mickmackusa ♦, Commented Sep 23, 2018 at 10:44

Shobi · Accepted Answer · 2018-09-18 07:00:43Z

1

${"T$index"} as well as ${"Weightage$index"}

you don't need the dot,or you can use ${'T' . $index}. look at the dot. it's not addition operation while it in "". following this code:

if($BrickTerritorys)
{
    foreach($BrickTerritorys as $index=>$BrickTerritory)
    {
        ${"$T.$index"}= $BrickTerritory->TerritoryID;
        ${"'Weightage'.$index"} = $BrickTerritory->Weightage;
    }
    echo $T1."-".$T2."--".$Weightage1."---".$Weightage2; exit;
}

edited Sep 18, 2018 at 7:00

Shobi

11.7k8 gold badges54 silver badges94 bronze badges

answered Sep 18, 2018 at 6:39

heihei

907 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Salman Over a year ago

Your 1 point is wrong, it start from 1 and clearly mentioned in question detail. and your second point is absolutely OK, i it working now . Thumb up for you (y)

mickmackusa Over a year ago

I don't like the quoting in this answer. I feel this answer is incorrect. Is this tested?

mickmackusa Over a year ago

@Salman this answer is no good. It only produces Notices and not the correct output. Totally wrong. Proof: 3v4l.org/YEejB Please rethink your green tick for the good of this community.

mickmackusa Over a year ago

Who keeps upvoting this incorrect answer? This will DEFINITELY mislead/confuse researchers.

AnTrakS · Accepted Answer · 2018-09-18 06:36:50Z

1

Try changing those lines like this:

        ${"T$index"}= $BrickTerritory->TerritoryID;
        ${"Weightage$index"} = $BrickTerritory->Weightage;

In your code ${"$T.$index"} $T is searching for variable, and you should get undefined variable $T, so you have to remove $ sign, if you want to have T1, T2 variables.

After that, ${"'Weightage'.$index"}, the apostrophes between Weightage means your variable will look like 'Weightage'.1, 'Weightage'.2.. and etc.

edited Sep 18, 2018 at 6:36

answered Sep 18, 2018 at 6:29

AnTrakS

7514 silver badges18 bronze badges

1 Comment

mickmackusa Over a year ago

@Salman This answer DOES provide the desired output WITHOUT Notices. Proof: 3v4l.org/i0rVo

mickmackusa · Accepted Answer · 2018-09-18 07:00:57Z

1

This can be done a few different ways without variable variables AND produce a completely dynamic outcome.

Here's one: (Demo)

$array = (array)$BrickTerritorys;             // cast as array
$tids = array_column($array, 'TerritoryID');  // isolate column data
$was = array_column($array, 'Weightage');     // isolate column data
$merged = array_merge($tids, $was);           // add 2nd array data after 1st array data
foreach ($merged as $i => $v) {
    echo str_repeat('-', $i) , $v;            // increase hyphens on each iteration starting from 0
}

Output: (notice, no hardcoded echo)

HYD-2-CMD-HYD-1-CMD--40.00---60.00

answered Sep 18, 2018 at 7:00

mickmackusa♦

49.2k13 gold badges98 silver badges165 bronze badges

Collectives™ on Stack Overflow

Create PHP Variables dynamically in foreach loop

3 Answers 3

4 Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related