Upload file not working if checking for uploaded files is on the code

Question

The images are uploading normally, but I want an "else if" to check if there is any file selected. This is working:

    <?php
session_start();
    include('includes/conexao.php');
    $fileinfo=PATHINFO($_FILES["image"]["name"]);
    $newFilename=$fileinfo['filename'] ."_". time() . "." . $fileinfo['extension'];
    move_uploaded_file($_FILES["image"]["tmp_name"],"images/perfis/" . $newFilename);
    $location="images/perfis/" . $newFilename;

$todas_fotos = mysqli_query($conexao, "select * FROM esc_usuarios_fotos WHERE img_usu_codigo = '" . $_SESSION['codigo'] . "'");

if( mysqli_num_rows($todas_fotos) > 0) {
        //$path=$location;
        //if(unlink($path)) echo "Deleted file ";
        mysqli_query($conexao,"UPDATE esc_usuarios_fotos SET img_local = '$location' WHERE img_usu_codigo = '" . $_SESSION['codigo'] . "'");
}
else if( mysqli_num_rows($todas_fotos) == 0)
{
        mysqli_query($conexao,"insert into esc_usuarios_fotos (img_local, img_usu_codigo) values ('$location', '" . $_SESSION['codigo'] . "')");
}
else {

};
    header('location:perfil.php');
?>

It inserts if there isn't an image, but if there is, it updates. But when I add:

else if (empty($_FILES['image']['name']))
{
header('location:perfil.php');
}

It returns me undefined index: extension on line 5. How to go?

first of all check print_r($_FILES) you will get the solution. — devpro
– devpro, Commented Sep 19, 2018 at 15:14
there you go: "Array ( [image] => Array ( [name] => [type] => [tmp_name] => [error] => 4 [size] => 0 ) ) Notice: Undefined index: extension on line 6", i don't even... — user8190735
– user8190735, Commented Sep 19, 2018 at 15:40

Rinsad Ahmed · Accepted Answer · 2018-09-20 00:19:08Z

1

Rewrite the code as follows. Here we are checking whether the file is not available at the beginning of the code and redirect if no file is found.

<?php
session_start();
if (empty($_FILES['image']['name']))
{
  header('location:perfil.php?error=1');
  return;
}
include('includes/conexao.php');
$fileinfo=PATHINFO($_FILES["image"]["name"]);
$newFilename=$fileinfo['filename'] ."_". time() . "." . $fileinfo['extension'];
move_uploaded_file($_FILES["image"]["tmp_name"],"images/perfis/" . $newFilename);
$location="images/perfis/" . $newFilename;

$todas_fotos = mysqli_query($conexao, "select * FROM esc_usuarios_fotos WHERE 
img_usu_codigo = '" . $_SESSION['codigo'] . "'");

if( mysqli_num_rows($todas_fotos) > 0) {
    //$path=$location;
    //if(unlink($path)) echo "Deleted file ";
    mysqli_query($conexao,"UPDATE esc_usuarios_fotos SET img_local = '$location' WHERE img_usu_codigo = '" . $_SESSION['codigo'] . "'");
 }else {
    mysqli_query($conexao,"insert into esc_usuarios_fotos (img_local, img_usu_codigo) values ('$location', '" . $_SESSION['codigo'] . "')");
 }

and in the perfil.php you should put

window.onload = function(){ var url = new URL(window.location.href); var error = url.searchParams.get("error"); if(error==1) alert("No file uploaded");

}

edited Sep 20, 2018 at 0:19

answered Sep 19, 2018 at 15:40

Rinsad Ahmed

1,9431 gold badge12 silver badges28 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

user8190735 Over a year ago

This did the trick! Just one more question, where can I put a little script to show an alert that no files were selected?

devpro Over a year ago

this is perfect

user8190735 Over a year ago

i have tried using $message = "Você não selecionou uma imagem!"; echo "<script type='text/javascript'>alert('$message');</script>"; after the header, but didn't worked at all

Rinsad Ahmed Over a year ago

@LuannSousa I should provide it as a separate code segment. I don't know whether we can submit it as another answer. The code perfil.php should be modified here

Rinsad Ahmed Over a year ago

Edited please check

|

Collectives™ on Stack Overflow

Upload file not working if checking for uploaded files is on the code

1 Answer 1

10 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

10 Comments

Your Answer

Sign up or log in

Post as a guest

Related