ASP.NET core return Bad object from controller

Question

I have repo method, that update entry in database. Here is code from repo method

 public async Task<string> UpdateProfile(string email, string firstname, string lastname, DateTime birthday)
    {
        string result;
        var user = _context.AspNetUsers.Where(x => x.Email == email).FirstOrDefault();
        user.FirstName = firstname;
        user.LastName = lastname;
        user.Birthday = birthday;
        await _context.SaveChangesAsync();
        result = "Updated";
        return result;
    }

And here is how I call it from controller

[HttpPost]
    public JsonResult UpdateProfile([FromBody] ProfileViewModel profile)
    {
        var result = _profile.UpdateProfile(profile.Email, profile.FirstName, profile.LastName, profile.Birthday);
        return Json(result);
    }

But in postman I see Bad object, but entry is updated.

Why I get this and how I can fix this?

Thank's for help.

Shouldn't you be awaiting the task? Otherwise your controller method will hit the return statement before result is assigned by the async callback. Try var result = await _profile.UpdateProfile(profile.Email, profile.FirstName, profile.LastName, profile.Birthday); — akerra
– akerra, Commented Sep 19, 2018 at 19:42

Mohsin Mehmood · Accepted Answer · 2018-09-19 20:01:24Z

2

Update method like this:

[HttpPost]
    public async Task<IActionResult> UpdateProfile([FromBody] ProfileViewModel profile)
    {
        var result = await _profile.UpdateProfile(profile.Email, profile.FirstName, profile.LastName, profile.Birthday);
        return Ok(result);
    }

Changed return type to IActionResult and also made the controller action async.

edited Sep 19, 2018 at 20:01

answered Sep 19, 2018 at 19:42

Mohsin Mehmood

4,2662 gold badges15 silver badges18 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Eugene Sukh Over a year ago

Yeah, but you have error . public async Task<IActionResult> is correct one

Collectives™ on Stack Overflow

ASP.NET core return Bad object from controller

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related