JS: sort array by two fields

Question

Now I have such code:

    sortArticles = (someArray) => {
        const result = [];

        let isValid = someArray.filter(item => item.isValid);
        let isInvalid = someArray.filter(item => !item.isValid);

        valid = funcSortArrayOfObjByKey(arrayChecked, 'article');
        invalid = funcSortArrayOfObjByKey(arrayUnchecked, 'article');
        // funcSortArrayOfObjByKey - is a function to sort, a kind of lodash implementation without unnecessary dependency 

        return result.concat(valid).concat(invalid);
    }

and I want to sort such array:

[
    {
        article: 'Some New Zarticle',
        isValid: false
    },
    {
        article: 'Some New Article',
        isValid: false
    },
    {
        article: 'Some New Zzarticle',
        isValid: true
    },
]

as result I want to see such array:

[
    {
        article: 'Some New Zzarticle',
        isValid: true
    },
    {
        article: 'Some New Article',
        isValid: false
    },
    {
        article: 'Some New Zarticle',
        isValid: false
    },
]

So: I need to have some kind of two arrays: first one, and second one (one with 'isValid', other without) and both of them should be sorted by 'article'. Is this possible to do somehow? I tried also this way:

someArray.sort((a, b) => {
  if (a.isValid === b.isValid) {
    return b.isValid - a.isValid;
  } else {
    return a.article.toLowerCase().localeCompare(b.article.toLowerCase());
  }
})

but it's not working as I want it...

Notice that your sortArticles() function creates a new array while someArray.sort() mutates the input. — Bergi
– Bergi, Commented Sep 30, 2018 at 13:05

Bergi · Accepted Answer · 2018-09-30 13:11:53Z

1

Your branches are inverted:

someArray.sort((a, b) => {
  if (a.isValid != b.isValid) {
//              ^^
    return b.isValid - a.isValid;
  } else {
    return a.article.localeCompare(b, undefined, { sensitivity: 'base' });
  }
})

answered Sep 30, 2018 at 13:11

Bergi

671k162 gold badges1k silver badges1.5k bronze badges

Sign up to request clarification or add additional context in comments.

7 Comments

byCoder Over a year ago

it won't work if, for example one of objects don't has this field (undefined) - how to deal then?

Bergi Over a year ago

@brabertaser19 Uh, you didn't say anything about that in the question? Which field can be missing, and how do you want to treat it?

Bergi Over a year ago

@brabertaser19 Of course the easiest way to fix it would be to keep your objects valid at all times, and simply add the field before sorting.

byCoder Over a year ago

isValid for example can be undefined (sure, normally it's not going to happen... but)

Bergi Over a year ago

@brabertaser19 But what? Make it to never happen. If you want the sort to handle isValid values other than true and false, you will need to adjust the sort to do it explicitly.

|

sperjesi · Accepted Answer · 2018-09-30 15:08:38Z

0

I was able to use this method to sort your array based on isValid then article.

someArray.sort(function(a, b) {
    if (a.isValid === b.isValid) {
        return a.article.localeCompare(b.article);
    } else {
        return (a.isValid) ? -1 : 1;
    }
});

answered Sep 30, 2018 at 15:08

sperjesi

113 bronze badges

Collectives™ on Stack Overflow

JS: sort array by two fields

2 Answers 2

7 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

7 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related