Insert string to SQL using C#

Question

I'm having an issue at the moment which I am trying to fix. I just tried to access a database and insert some values with the help of C#

My code:

SqlConnectionStringBuilder builder = new SqlConnectionStringBuilder();

builder.DataSource = "testtetstet.database.windows.net";
builder.UserID = "PW";
builder.Password = "000000000";
builder.InitialCatalog = "test";

using (SqlConnection connection = new SqlConnection(builder.ConnectionString))
{
    String query = "INSERT INTO dbo.amir (theDate,Hostname,IP) VALUES (@theDate,@hostName, @IP)";

    using (SqlCommand command = new SqlCommand(query, connection))
    {
        command.Parameters.Add("@theDate");
        command.Parameters.Add("@hostName");
        command.Parameters.Add("@IP");

        connection.Open();
        var result = command.ExecuteNonQuery();

        // Check Error
        if (result < 0)
            Console.WriteLine("Error inserting data into Database!");
    }
}

What I'm trying to do is, insert 3 strings in to the sql database but it seems that it does not work!!

"@hostname"is a string which contains the computer name "@IP" is a string which contains the IP adress "@theDate" is a DateTime string which display date and time.

What am I doing wrong?

Isn't it obvious? You're not supplying any values to the parameters you're adding. Try command.Parameters.Add("@theDate").Value = DateTime.UtcNow, etc. — ProgrammingLlama
– ProgrammingLlama, Commented Oct 4, 2018 at 6:20
what error/exception you are getting exactly? Please put try catch blocks to handle the exception — KamalaH
– KamalaH, Commented Oct 4, 2018 at 6:21
As per John's comment, you probably should read Msdn SqlCommand.Parameters Property — Rafalon
– Rafalon, Commented Oct 4, 2018 at 6:23
@John Correct. You should pass the values. Values may be from textbox or any object. Please check Refer this code: command.Parameters.Add("@theDate",dateValue); command.Parameters.Add("@hostName",hostValue); command.Parameters.Add("@IP",IpValue); — KamalaH
– KamalaH, Commented Oct 4, 2018 at 6:23

Ashkan Mobayen Khiabani · Accepted Answer · 2018-10-04 07:43:28Z

7

You are not setting the value of parameter.You should either Use Parametrs.Add like this:

command.Parameters.Add("@IP", SqlDbType.VarChar).Value = "0.0.0.0";
//equals to:
//command.Parameters.Add("@IP", SqlDbType.VarChar); 
//command.Parameters["@IP"].Value = "0.0.0.0";

or (not recommended):

command.Parameters.AddWithValue("@IP", "0.0.0.0");

edited Oct 4, 2018 at 7:43

answered Oct 4, 2018 at 6:34

Ashkan Mobayen Khiabani

34.3k35 gold badges111 silver badges187 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Zohar Peled Over a year ago

Can we stop using AddWithValue() already?

Ashkan Mobayen Khiabani Over a year ago

I was just showing possible ways, not recommending one.

Zohar Peled Over a year ago

Well, you should be recommending one. After all, we are here to help...

Amir Over a year ago

Thank you Ashkan!

Adam Miklosi · Accepted Answer · 2018-10-04 06:30:04Z

6

You don't pass any values to the parameters. Try something like this:

command.Parameters.AddWithValue("@theDate", date);
command.Parameters.AddWithValue("@hostName", host);
command.Parameters.AddWithValue("@IP", ip);

answered Oct 4, 2018 at 6:30

Adam Miklosi

7625 gold badges19 silver badges29 bronze badges

1 Comment

Zohar Peled Over a year ago

Can we stop using AddWithValue() already?

Collectives™ on Stack Overflow

Insert string to SQL using C#

2 Answers 2

4 Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related