Using a java.sql.Timestamp object in an sql query

Question

I am trying to run a query in java that uses a java.sql.Timestamp object as the date to compare with in the where clause.

Here is how the query string that is built in Java

 String getTransactionsSQL =  "Select transaction_seq " +
    "From transactions ct " +
    "Where id = 'ABCD'" + 
    "And ct.out_msg_timestamp" +
    "<= to_date('" + parseDate.getTimeStamp() +"','YYYY-MM-DD HH:MI:SS..')" +
    "order by transaction_seq";

The statement parseDate.getTimeStamp() returns a java.sql.TimeStamp object that contains a date. Here is an example output of System.out.println(parseDate.getTimeStamp());

2011-03-07 05:47:57.0

When i run the above query i get this error

 java.sql.SQLException: ORA-01843: not a valid month

Any clues?

Brilliant thanks. I have changed it to use PreparedStatement and SetTimeStamp. — ziggy
– ziggy, Commented Mar 10, 2011 at 20:04

Puce · Accepted Answer · 2011-03-10 19:48:41Z

7

Use PreparedStatement: http://download.oracle.com/javase/6/docs/api/java/sql/PreparedStatement.html

Never use string concatenation to pass arguements to SQL commands (security risk: SQL injection)!

answered Mar 10, 2011 at 19:48

Puce

38.3k14 gold badges87 silver badges159 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Puce Over a year ago

Here's the tutorial: download.oracle.com/javase/tutorial/jdbc/basics/prepared.html

Lukas Eder Over a year ago

I have to copy that! You should not use String concatenation in SQL like that

BalusC Over a year ago

To be more precise, you should use preparedStatement.setTimeStamp(index, timeStamp);.

ziggy Over a year ago

Thanks guys but is this not only a problem for web based applications? Is it also possible for daemon type applications?

user330315 Over a year ago

@Ziggy: you should never use string literals for dates/timestamps. Always use a PreparedStatement, it's not only about SQL injenction but also about maintainability and robustness. When converting a date/timestamp to a string you are always influenced by locale settings (and maybe even different JDK versions)

|

Collectives™ on Stack Overflow

Using a java.sql.Timestamp object in an sql query

1 Answer 1

6 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related