Asp.net Web API | Document Upload Async await or Task.Run

Question

I've asp.net web API integrated with public ui web site

the website will have many concurrent users that submit applications , api pull this to database.

the API do a lot functions like :

Get Data
Update Data
Upload files

I'm trying to use Async operations ( specially in upload documents )

I edited all function to use await Task.Run()=>bla())) , like this :

if (Someconditions)
{
await Task.Run(() => Function1());
await Task.Run(() => Function2())
if (Someconditions)
await Task.Run(() => Function3())

if (Someconditions)
await Task.Run(() => CreateUpdateDocumentDetails)); // Uploading document

For document upload function , I'm very confused

Should I use await UploadDocumentAsync() or

Task.Run(()=>UploadDocumetSync()) or Task.Run(()=>UploadDocumentAsync())

Also Does Task.Run(SyncFunc()) mean all above function runs asynchronously without marked them as async and is it good practice?

Last questions what's the difference between this and making all functions (async / await)

It's usually a bad sign of poor design when you are calling Task.Run() inside an web API request handler -- especially when using a conventional controller or request handler shipped with ASP.NET Core. — Svek
– Svek, Commented Oct 22, 2018 at 10:34

PrathapG · Accepted Answer · 2018-10-20 10:04:12Z

0

1 .It's an uploading process better is Async

2 .Use Task.Run(()=>UploadDocumentAsync());

3 .Async tells caller, I am an asynchronous method, don't wait for me.await inside the Task() ask for waiting for an asynchronous task.

for example after running below program will wait 10 seconds to show the task done.

public static void Main(string[] args){
     Task();
     System.Console.WriteLine("main thread is running while waiting");
     Console.ReadLine();
}
private static async void Task(){
     await Task.Delay(10000);
     Console.WriteLine("Waited for 10s");
}

answered Oct 20, 2018 at 10:04

PrathapG

7891 gold badge7 silver badges23 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ahmed Gharib Over a year ago

thank you for clarification , what happens if use Task.Run()=>SyncMethod()) , will this occurs async or as the original function is sync , it will run sync and ignore task

Collectives™ on Stack Overflow

Asp.net Web API | Document Upload Async await or Task.Run

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related