Removing items in a loop and adding a new array

Question

I want to add data into a new array and remove data from the current list on a button click. Right now it only removes the last item and sometimes two checked items not 4-6 items.

$scope.LoadBack = function () {
  for (var i = 0; i < $scope.MyArrold.length; i++) {
    if ($scope.MyArrold[i].checked == true) { 
      $scope.BackList.push(angular.extend({}, $scope.MyArrold[i]));            
      var index = $scope.MyArrold.indexOf($scope.MyArrold[i]);
      $scope.MyArrold.splice(index, 1);
    }
  }
}

just add i--; after you splice the array.

Gaurav Singh
– Gaurav Singh

2018-10-22 07:51:09 +00:00
Commented Oct 22, 2018 at 7:51 — Gaurav Singh
– Gaurav Singh, Commented Oct 22, 2018 at 7:51

Dale K · Accepted Answer · 2018-10-21 21:38:02Z

1

You're removing items from the array while you are in a loop which is iterating over the array. That doesn't work.

One way to solve this is to add the items you want to keep to a temp array and then assign that array back to MyArrold after the loop completes.

Another way to solve this is to track the indexes you wish to remove in a temp array, and then iterate over this array after the loop completes, backwards! To use this solution you have to iterate backwards else all future indexes become invalid.

edited Oct 21, 2018 at 21:38

answered Oct 21, 2018 at 20:42

Dale K

28.1k15 gold badges59 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

bkent · Accepted Answer · 2018-10-22 20:26:37Z

0

var i = $scope.MyArrold.length;
while (i--) {
   if ($scope.MyArrold[i].checked === true) {          
      $scope.MyArrold.splice(i, 1);
   }
}

answered Oct 22, 2018 at 20:26

bkent

111 bronze badge

Collectives™ on Stack Overflow

Removing items in a loop and adding a new array

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related