Setting multiple model attributes at once via loop

Question

Im using virtual attributes to concat and form a address before i save the user. So when they click edit user i would like to populate the fields in the form again. Every time i try to assign them they come back nil?

This is what i call from devise registrations controller before_action edit:

def test
 resource.populate_address_attributes
end

and here is the method im trying to work with:

def populate_address_attributes
  if address == nil || address == ""
    return false
  else
    attributes = address.split(",")
    [self.number, self.street_name, self.area, self.postcode, self.state].each { |x| x = attributes.delete_at[0]}
  end
end

all i'm getting is this:

=> [nil, nil, nil, nil, nil]

maybe i'm trying to make it to complicated?

Ill add the attributes array is populated correctly with the address split up — john seymour
– john seymour, Commented Oct 22, 2018 at 11:02
Why do you store the address as a single comma separated string? — Stefan
– Stefan, Commented Oct 22, 2018 at 11:28
because geocoder allows it with comma's and i cant split with " " incase of multiple words in the street name or city — john seymour
– john seymour, Commented Oct 22, 2018 at 11:41
Storing the address as a single concatenated comma seperated string seems like a really bad idea since addresses may actually contains commas (596 Ocean Blvd, APT 162) for example. The idea of being able to parse addresses with simple methods is utterly flawed. You're basically taking good seperated data and turing it into junk. — max
– max, Commented Oct 22, 2018 at 17:01

score 1 · Accepted Answer · 2018-10-23 08:23:47Z

1

When you are passing [self.number, self.street_name] etc you are passing the value of those attributes (which are nil and hence immutable).

Try this

def populate_address_attributes
  if address == nil || address == ""
    return false
  else
    attributes = address.split(",")
    [:number, :street_name, :area, :postcode, :state].each_with_index do |field, index|
      self.public_send("#{field}=", attributes[index])
    end
  end
end

edited Oct 23, 2018 at 8:23

answered Oct 22, 2018 at 11:14

user3723506

Sign up to request clarification or add additional context in comments.

11 Comments

john seymour Over a year ago

can't write unknown attribute field

user3723506 Over a year ago

sorry, there was a bug, fixed. Try again

user3723506 Over a year ago

Should had been self[field] instead of self[:field]

john seymour Over a year ago

now its throwing "*** ActiveModel::MissingAttributeError Exception: can't write unknown attribute number" In byebug i can set self.number to 3 and then self[field] is showing nil and it should be 3. Im a bit confused!

john seymour Over a year ago

So i think i understand it, basically i was storing the values of the variables in the array, not setter methods. so by calling public send(number, 4) on the user object its effectively calling the setter method in this case?

|

Collectives™ on Stack Overflow

Setting multiple model attributes at once via loop

1 Answer 1

11 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

11 Comments

Your Answer

Sign up or log in

Post as a guest

Related