PhP foreach through class instances

Question

I'm wondering about this weird thing:

public function getAllCustomers()
{
    $customers = $this->redis->keys("customer:*");
    foreach ($customers as $value) {
        return new \Customer($this->redis->hget($value,"name"),$this->redis->hget($value,"id"),$this->redis->hget($value,"email"));
    }
}

This method returns all customers from my database.

But if I try to loop through all of these customers:

foreach ($customerController->getAllCustomers() as $customer) {
    var_dump($customer);
}

The getName() method is not found. var_dump returns:

NULL
NULL
NULL

Customer class:

class Customer {
    var $name;
    var $id;
    var $email;

    function __construct($name, $id,$email) {
        $this->name = $name;
        $this->id = $id;
        $this->email = $email;
    }

     /**
     * @return mixed
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return mixed
     */
    public function getId()
    {
        return $this->id;
    }

    /**
     * @return mixed
    */
    public function getEmail()
    {
        return $this->email;
    }

    public function __toString()
    {
       return "";
    }
}

I'm pretty new to PHP and don't understand why I can't access the Customer object's field.

Can you please add var_dump or print_r on the $customer in your for-loop? — dWinder
– dWinder, Commented Oct 31, 2018 at 15:42
You are returning INSIDE a foreach loop. So that loop will run only once — RiggsFolly
– RiggsFolly, Commented Oct 31, 2018 at 15:43
return array(\Customer(... - are you also missing a new here? The code you've posted should just cause a syntax error. — iainn
– iainn, Commented Oct 31, 2018 at 15:44
You are STILL returning INSIDE the foreach loop and therefore only ONE Customer will be returned — RiggsFolly
– RiggsFolly, Commented Oct 31, 2018 at 15:55

dWinder · Accepted Answer · 2018-10-31 16:02:43Z

2

Your Problem: you do not return array of customer but only one. You getting null because your function return only 1 object -> and in PHP, when using foreach loop on object you get his fields -> and the fields do not have the getName function.

Solution: Init customer array, populate it and return from the function.

 public function getAllCustomers()
{
    $customers = $this->redis->keys("customer:*");
    $customersObjs = array();
    foreach ($customers as $value) {
        $customersObjs[] = new Customer($this->redis->hget($value,"name"),$this->redis->hget($value,"id"),$this->redis->hget($value,"email")));
    }
    return $customersObjs;
}

Now you have array of the customersObjs you can loop on with:

foreach ($customerController->getAllCustomers() as $customer) {
    echo $customer->getName();
}

edited Oct 31, 2018 at 16:02

answered Oct 31, 2018 at 15:52

dWinder

11.7k3 gold badges27 silver badges40 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

FileInputStream Over a year ago

This solved my problem. @RiggsFolly This method is also returning inside the foreach loop and it is working.

Patrick Q Over a year ago

"is also returning inside the foreach loop" No, it definitely is not. Please take the time to review the difference between this and what you had. You might also want to review the documentation for what exactly return does.

FileInputStream Over a year ago

Sorry for that, my mistake.

Jose Rodriguez · Accepted Answer · 2018-10-31 15:56:32Z

1

Solution :

public function getAllCustomers()
{
    $customers = $this->redis->keys("customer:*");
    $custumersArray = array();
    foreach ($customers as $value) {
        $custumersArray[] = \Customer($this->redis->hget($value,"name"),$this->redis->hget($value,"email"),$this->redis->hget($value,"id"));
    }
    return $custumersArray;
}

the problem was that you are returning a single array but not a array list.

answered Oct 31, 2018 at 15:56

Jose Rodriguez

2472 silver badges7 bronze badges

Collectives™ on Stack Overflow

PhP foreach through class instances

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related