How to split string object and then concatenate and add to array

Question

This addtoTaskList function needs to split the received task into 2 arrays(?) or two tasks split by a comma, then concatenate them and add them to the tasks array. As the code is currently, it outputs the split values to the taskList, but also outputs a non-split duplicate and clears the task list after every entry as shown below: Duplicate Output

I mostly need help with the concatenation, I think-thanks!

"use strict";
var $ = function(id) { return document.getElementById(id); };

var tasks = [];

var displayTaskList = function() {
    var list = "";
    // if there are no tasks in tasks array, check storage
    if (tasks.length === 0) {
        // get tasks from storage or empty string if nothing in storage
        var storage = localStorage.getItem("tasks") || "";

        // if not empty, convert to array and store in global tasks variable
        if (storage.length > 0) { tasks = storage.split("|"); }
    }

    // if there are tasks in array, sort and create tasks string
    if (tasks.length > 0) {
       // tasks.sort();
        list = tasks.join("\n");
    }
    // display tasks string and set focus on task text box
    $("task_list").value = list;
    $("task").focus();
};

var addToTaskList = function() {   
    var task = $("task");
    if (task.value === "") {
        alert("Please enter a task.");
    } else {  

        // add task to array and local storage
        var partsOfStr = task.value.split(',');
        tasks = partsOfStr.concat(task.value);

        localStorage.tasks = tasks.join("|");

        // clear task text box and re-display tasks
        task.value = "";
        displayTaskList();
    }
};

var clearTaskList = function() {
    tasks.length = 0;
    localStorage.tasks = "";
    $("task_list").value = "";
    $("task").focus();
};

window.onload = function() {
    $("add_task").onclick = addToTaskList;
    $("clear_tasks").onclick = clearTaskList;    
    displayTaskList();
};

Though not necessary, I recommend you use JSON.stringify(tasks) and JSON.parse(storage) instead of joining and splitting your array with "|" characters. That way if someone enters a "|" when adding a task, it doesn't add extra values to your tasks array. — Jason
– Jason, Commented Nov 2, 2018 at 3:26
Thank you!!! So sorry for wasting your time :( U are my hero man — James Holloway
– James Holloway, Commented Nov 2, 2018 at 3:30

Jason · Accepted Answer · 2018-11-02 02:42:47Z

1

You are trying to concatenate an array (partsOfStr) with a string (task.value). Perhaps you meant to use tasks instead of task.value?

tasks = partsOfStr.concat(task.value);

Should be:

tasks = tasks.concat(partsOfStr);

answered Nov 2, 2018 at 2:42

Jason

1,07911 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

James Holloway Over a year ago

Thanks Jason, unfortunately I tried that previously, and it results in no output...

Jason Over a year ago

@JamesHolloway I can't seem to reproduce your issue. Are you making sure to assign the result of the concat() operation to tasks? concat() does not modify the original array, it simply returns a new concatenated array.

James Holloway Over a year ago

Oh my Lord Jason, I am so sorry man, your solution worked! I had a capitalization error-oof!! thank you so much

Collectives™ on Stack Overflow

How to split string object and then concatenate and add to array

1 Answer 1

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related