Insert data in database in Drupal

Question

I want to insert a result in mysql, i use this query:

$sql= "INSERT into {test} WHERE Id = $currentID (soortstage)VALUES('%s')";

that is the error:

* user warning:

You have an error in your SQL syntax;
check the manual that corresponds to
your MySQL server version for the
right syntax to use near  `WHERE Id =
(Soortstage)VALUES('132')'` at line 1
query: `INSERT into test WHERE  Id =
(Soortstage)VALUES('132') in
C:\xampp\htdocs\testplanning\modules\planning\planning.module on line 425.`

* warning: 

Invalid argument supplied for
foreach() in
`C:\xampp\htdocs\testplanning\includes\form.inc
on line 1213.`

Have someone a idea? Thanks!

I want to insert values in a created row. the $currentID is the row that I will insert a value to. In these row there are some fields empty and I will just insert 1 value. — user001
– user001, Commented Mar 15, 2011 at 13:24
So you want to UPDATE the row, maybe you should learn the basics of SQL first, you won't regret doing that... — wimvds
– wimvds, Commented Mar 15, 2011 at 14:30

berkes · Accepted Answer · 2011-03-15 14:20:43Z

1

You might be looking for REPLACE, which will either UPDATE or INSERT based on whether or not the primary ID of the record exists.

REPLACE INTO {test} WHERE Id = $currentID (soortstage) VALUES('%s')

But, frankly, you mention Drupal, which has a nice helper for this: http://api.drupal.org/api/drupal/includes--common.inc/function/drupal_write_record/6

answered Mar 15, 2011 at 14:20

berkes

27.7k30 gold badges125 silver badges220 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Berdir Over a year ago

More importantly, this query should use proper placeholders for $currentID (aka %d), this is not safe. Also, REPLACE is MySQL specific. To be compatible with PostgreSQL, you need to something like api.drupal.org/api/drupal/includes--bootstrap.inc/function/…

berkes Over a year ago

Indeed: When @Yannick wants to make a proper, re-usable Drupal-module, the query should be generic and not MySQL-specific. But since he stated he uses MySQL, I thought that to be less important :)

Gaurav · Accepted Answer · 2011-03-15 13:25:38Z

0

You need an update query

$sql= "UPDATE {test} SET soortstage = '%s' WHERE Id = $currentID ";

answered Mar 15, 2011 at 13:25

Gaurav

28.8k9 gold badges54 silver badges81 bronze badges

2 Comments

user001 Over a year ago

almost good solution, but it gives this error: * user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 query: UPDATE test SET Soortstage = '162' WHERE Id = in C:\xampp\htdocs\testplanning\modules\planning\planning.module on line 426. * warning: Invalid argument supplied for foreach() in C:\xampp\htdocs\testplanning\includes\form.inc on line 1213.

Gaurav Over a year ago

it is because $currentID does not have any value

Collectives™ on Stack Overflow

Insert data in database in Drupal

2 Answers 2

2 Comments

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related