Matching _{number} with Regex in javascript

Question

I am trying the match part of an image src, an example would be:

images/preview_1.jpg

and I want to change _1 to say _6

so I’m trying to match _1

function ClickImgOf(filename, itemid){
   var re = new RegExp("(.+)_[0-9])\\.(gif|jpg|jpg|ashx|png)", "g");
   return filename.replace(re, "$1_"+itemid+".$2");
}

Is the function I have..

I know that only matches 0-9 but I was just trying to get something to work and even that didn't.

Its fair to say I do not know much about Regex at the moment.

Justin Morgan · Accepted Answer · 2011-03-15 14:30:24Z

3

You have an unmatched ) parenthesis there in your pattern. Is that what's throwing you off? Looks okay otherwise. If your problem is being able to match 2-or-more-digit numbers, try [0-9]+.

function ClickImgOf(filename, itemid){
   var re = new RegExp("(.+)_([0-9]+)\\.(gif|jpg|jpg|ashx|png)", "g");
   return filename.replace(re, "$1_"+itemid+".$3");
}

answered Mar 15, 2011 at 14:30

Justin Morgan

30.7k13 gold badges82 silver badges109 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

David McLean Over a year ago

woops! not the first time missing a ) has led to me pulling my hair out! Thanks

Town · Accepted Answer · 2011-03-15 14:38:15Z

1

Try this:

(.+_)[0-9]+(\.(?:gif|jpg|jpg|ashx|png))

Then you can just do:

return filename.replace(re, "$1" + itemid + "$2");

Also, download and install this: http://www.ultrapico.com/ExpressoDownload.htm

It's invaluable when working with regular expressions.

edited Mar 15, 2011 at 14:38

answered Mar 15, 2011 at 14:32

Town

14.9k3 gold badges50 silver badges72 bronze badges

2 Comments

David McLean Over a year ago

Have you seen this -> regexhero.net/tester ? its also pretty damn good when working with regex.

Town Over a year ago

Yeah, that's also good! Basically you just need a regex tester of some description, it'll save a lot of time as I'm sure you've found! :)

Martin Jespersen · Accepted Answer · 2011-03-15 14:41:29Z

1

You don't need to build your regex using the regex object, it's both easier and performs better to use a literal.

function ClickImgOf(filename, itemid) {
   return filename.replace(/_\d+\.(gif|jpg|jpg|ashx|png)$/g, '_'+itemid+'.$2');
}

answered Mar 15, 2011 at 14:41

Martin Jespersen

26.3k8 gold badges60 silver badges69 bronze badges

Collectives™ on Stack Overflow

Matching _{number} with Regex in javascript

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related