convert nested for loop to linq with condition

Question

How to convert below c# nested for loop to linq...?

 list = objBLForms.GetForms(Ids);
            for (int i = 0; i < list.Count; i++)
            {
                for (int j = 0; j < list.Count; j++)
                {
                    if (list[i].StateId == list[j].StateId && 
                    list[i].PayerId == list[j].PayerId && i != j)
                    {
                        if (string.IsNullOrEmpty(list[i].Tax))
                        {
                            list.Remove(list[i]);
                        }
                        else
                        {
                            list.Remove(list[j]);
                        }
                    }
                }
            }

I want to Remove duplicate payers with same state..And if any state tax is present, i wanted to remove the other duplicate one i,e; the duplicate one which is having no state tax... I have achived it by using the nested for loop as shown above. is there any way to do it in linq..I dont't know anything about linq. Am very new to linq,Thanks in advance

Note that && i != j isn't needed: just start j at 1 rather than 0. — ProgrammingLlama
– ProgrammingLlama, Commented Nov 13, 2018 at 5:33
Both for loops start at 0 and both end at Count. You are bound to compare an object to its own self — Ahmad
– Ahmad, Commented Nov 13, 2018 at 5:39
yes @ahmmed.. i wanted to remove duplicates, so i need to compare to its own self only... — Kishore
– Kishore, Commented Nov 13, 2018 at 5:41

Lowkey · Accepted Answer · 2018-11-13 05:54:16Z

1

The logic of your code is actually removing EVERYTHING that has string.IsNullOrEmpty(Tax), and only keeping first record that has value in Tax. Then, how about this

list
    .Where(l => !string.IsNullOrEmpty(l.Tax))
    .GroupBy(l => new {l.StateId, l.PayerId})
    .Select(group => group.First())
    .ToArray();

edited Nov 13, 2018 at 5:54

answered Nov 13, 2018 at 5:32

Lowkey

8365 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Kishore Over a year ago

it removing every item where tax is empty...but only remove empty tax item when there exist an other duplicate item with tax, else keep that empty tax item in the list

Enigmativity · Accepted Answer · 2018-11-13 09:05:54Z

0

This seems about right to me:

list =
    list
        .OrderByDescending(x => x.Tax)
        .GroupBy(x => new { x.StateId, x.PayerId })
        .SelectMany(x => x.Take(1))
        .ToList();

answered Nov 13, 2018 at 9:05

Enigmativity

117k12 gold badges101 silver badges184 bronze badges

Collectives™ on Stack Overflow

convert nested for loop to linq with condition

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related