Access string variable created inside for-loop

Question

I'm creating an android app that converts ascii to binary. But I can't figure out on how to access a string I made outside the for-loop. if I type in binary(var name) android studio gives me an error. Here's my code(it's only in the on-click listener)

String output = "";
String input = textEditText.getText().toString();
int length = input.length();

for (int i = 0;i < length;i++) {
    char c = input.charAt(i);
    int value = Integer.valueOf(c);
    String binaryOutpt2 = Integer.toBinaryString(value);
    String binary = output + binaryOutpt2;
}

what is the error? Please give us more infos

Thelouras
– Thelouras

2018-11-18 15:24:46 +00:00
Commented Nov 18, 2018 at 15:24 — Thelouras
– Thelouras, Commented Nov 18, 2018 at 15:24
Have you learned "variable scope"?

OneCricketeer
– OneCricketeer

2018-11-18 15:32:06 +00:00
Commented Nov 18, 2018 at 15:32 — OneCricketeer
– OneCricketeer, Commented Nov 18, 2018 at 15:32

forpas · Accepted Answer · 2018-11-18 15:46:00Z

3

Use StringBuilder instead of String for the variable output, like this:

String input = textEditText.getText().toString();        
StringBuilder output = new StringBuilder();
int length = input.length();
for (int i = 0; i < length; i++) {
    char c = input.charAt(i);
    int value = (int) c;
    String s = Integer.toBinaryString(value);
    for (int j = 0; j < 8 - s.length(); j++) {
        output.append("0");
    }
    output.append(s);
}
String out = output.toString();

this way you append each binary value of each char at the initial output and finally you get the whole binary representation of the text.
Also pad zeroes at the start of each binary value until you get 8 binary digits for each char.

edited Nov 18, 2018 at 15:46

answered Nov 18, 2018 at 15:30

forpas

165k10 gold badges51 silver badges85 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Uncodeable864 Over a year ago

OK that makes more sense now

Collectives™ on Stack Overflow

Access string variable created inside for-loop

1 Answer 1

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related