How can I push data into an array?

Question

I have pushed some data into an array:

if(target === 'create'){
    if(name === 'form[username]' || name === 'form[name]' || name === 'form[slug]' || name === 'form[plainPassword]'){
        errors.push(name);
    }
} else {
    if(name === 'form[username]' || name === 'form[name]' || name === 'form[slug]' ){
        errors.push(name);
    }
}

It actually works fine. But it seems to me that it is really too much repeating code, but I still cannot find a way to reduce the code, or make a simpler better solution.

looking at this tiny piece of code that you have shown doesn't need any optimization. — Dhiren
– Dhiren, Commented Nov 26, 2018 at 12:04
@Dhiren Indeed, In fact, it could be shorter but it's just an if/else that cost nothing in programming languages. So there is no need to be optimized — Colin Cline
– Colin Cline, Commented Nov 26, 2018 at 12:06

JustLearning · Accepted Answer · 2018-11-26 12:14:54Z

2

I would do it in two methods

function CheckErrors(target,name){
   switch(target){
     case 'create':
       SaveError(name,true);
       break;
     default:
       SaveError(name);
       break;
    }
}

function SaveError(name,checkPassword){
     if(name === 'form[username]' || name === 'form[name]' || name === 'form[slug]' ||(checkPassword && name === 'form[plainPassword]')){
        errors.push(name);
    }
}

edited Nov 26, 2018 at 12:14

answered Nov 26, 2018 at 12:07

JustLearning

3,3423 gold badges37 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Colin Cline Over a year ago

I am afraid you missed something

JustLearning Over a year ago

just trying to figure out what i missed :)

Colin Cline Over a year ago

OP dont want to push 'form[plainPassword]' in else statement

JustLearning Over a year ago

indeed i see it. If i had to re-write it would still look ugly

Xorifelse · Accepted Answer · 2018-11-26 12:18:58Z

2

You could use arrays to simplify your if statement:

if((target === 'create' && name === 'form[plainPassword]') || ['form[username]', 'form[name]', 'form[slug]'].includes(name)){
  errors.push(name);
}

answered Nov 26, 2018 at 12:18

Xorifelse

7,9411 gold badge29 silver badges38 bronze badges

Comments

Andrei · Accepted Answer · 2018-11-26 12:09:43Z

1

If I rigth understand you, you want to simplify your statements. From my perspective it could be like this:

if(name === 'form[username]' || name === 'form[name]' || name === 'form[slug]' 
                             || (name === 'form[plainPassword]' && target === 'create')){
    errors.push(name);
}

Since:

name === 'form[username]' || name === 'form[name]' || name === 'form[slug]'

is repeated two times, it doesn't matter if target === 'create' is true or false for this statements.

In fact just add (name === 'form[plainPassword]' && target === 'create') to if statement and that's all

edited Nov 26, 2018 at 12:09

answered Nov 26, 2018 at 12:03

Andrei

5,6675 gold badges27 silver badges51 bronze badges

Collectives™ on Stack Overflow

How can I push data into an array?

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

4 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related