need to delete an element from array nodejs and mongodb

Question

how do i delete a productid say 5bbee0b7e5fcb61df834f7d6 from this arrat have tried

router.post('/empty-cart', isLoggedIn, function(req, res, next) {
  console.log("user" + req.body.user + ",product" + req.body.productId);
  slug = req.body.productId;
  user = req.body.user;
  User.findOne({ _id: user }, {
    $pull: { productId: slug }
  }, function(err, model) {})

  console.log(slug);
  meanlogger.log('trash', 'Emptied cart', req.user);

  res.redirect('/shopping-cart');
});

but seems like it wont apply for arrays as it considers only 1st element looking for suggestions

You have to use $pull with update, please refer to: docs.mongodb.com/manual/reference/operator/update/pull/… You will get a better Idea. — Vatsal Shah
– Vatsal Shah, Commented Nov 29, 2018 at 7:34

Aabid · Accepted Answer · 2018-11-29 07:04:54Z

1

You cannot use $pull with findOne you should to use update

router.post('/empty-cart', isLoggedIn, function(req, res, next) {
  console.log("user" + req.body.user + ",product" + req.body.productId);
  slug = req.body.productId;
  user = req.body.user;
  User.update({ _id: user }, { $pull: { productId: slug } }, function(err, model) {
    console.log(slug);
    meanlogger.log('trash', 'Emptied cart', req.user);
    res.redirect('/shopping-cart');
  })
});

this is the correct way.

answered Nov 29, 2018 at 7:04

Aabid

9515 silver badges24 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sameer Ds Over a year ago

thanks for response my query is i have an array productid and im doing nothing to loop through that array so cant achieve the requirement

Aabid Over a year ago

have you tried with update? if so, you will achieve your requirement. Query is tested and working fine, may be you have issue with user. Try to print and check the query.

Sameer Ds Over a year ago

yes i have been using update only now someone suggested to use findone let me test with user as you suggest

enxtur · Accepted Answer · 2018-11-29 08:31:06Z

0

There is another way. You should find document first, then pull by ObjectId.

router.post('/empty-cart', isLoggedIn, function (req, res, next) {
    console.log('user' + req.body.user + ',product' + req.body.productId);
    const slug = mongoose.Types.ObjectId(req.body.productId);
    const user = req.body.user;
    User.findOne({ _id: user }, function (err, model) {
        if (err) return res.redirect('/error-page');
        if (!model) return res.redirect('/notfound-page');
        model.productId.pull(slug);
        model.save(function (err) {
          if (err) return res.redirect('/error-page');
          console.log(slug);
          meanlogger.log('trash', 'Emptied cart', req.user);
          res.redirect('/shopping-cart');
        });
    });
});

edited Nov 29, 2018 at 8:31

answered Nov 29, 2018 at 7:32

enxtur

2,5451 gold badge18 silver badges16 bronze badges

3 Comments

Sameer Ds Over a year ago

hey Enxtur thanks for the answer seemed very much right but gave an error TypeError: Cannot read property 'productId' of null for this line model.productId.pull(slug);

enxtur Over a year ago

In your case, user not found by your input as req.body.user. Check your data dude :) and I edit my post for checking errors and model

Sameer Ds Over a year ago

yeah you are right that solved the issue i was retreving product id both end which led to error thanks for the help

Collectives™ on Stack Overflow

need to delete an element from array nodejs and mongodb

2 Answers 2

3 Comments

3 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

3 Comments

Your Answer

Sign up or log in

Post as a guest

Related