code optimization for multiple array using JavaScript

Question

I have two array

[{ Name: 'CVS 7201 Us Highway 64',Address: '7201 Us Highway 64',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'},
{ Name: 'CVS 9931 Gilead Road', Address: '9931 Gilead Road',CustomerID: '920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{ Name: 'Walgreens',Address: '2805 N Roosevelt Blvd',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'}]

[{TenantID:1,External_ID:'920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{TenantID:2,External_ID:'FB7BCE3B-E06E-420A-A342-08CF20054F78'}]

Filtered Data

[{ Name: 'CVS 7201 Us Highway 64',Address: '7201 Us Highway 64',TenantID:2},
{ Name: 'CVS 9931 Gilead Road', Address: '9931 Gilead Road',TenantID:1},
{ Name: 'Walgreens',Address: '2805 N Roosevelt Blvd',TenantID: 2}]

In my first array there are more then 5K record and in second array it's around 100+ I write some code but i am not happy with the way.

for (const data of recordset.recordset) {//5000
    for(var i in lstAllTenant){//120
        if(lstAllTenant[i].External_ID == data.CustomerID)
        {
            var pickupLocations = {
                TenantID: lstAllTenant[i].TenantID,
                Name: data.Name,
                Address: data.Address,
            }
            lstPickupLocations.push(pickupLocations);
        }
    }
}

How can i optimize this thing?

Nothing here ?

mplungjan
– mplungjan

2018-12-06 13:28:13 +00:00
Commented Dec 6, 2018 at 13:28 — mplungjan
– mplungjan, Commented Dec 6, 2018 at 13:28

Nurbol Alpysbayev · Accepted Answer · 2018-12-06 13:36:18Z

3

How about this

const source = [{ Name: 'CVS 7201 Us Highway 64',Address: '7201 Us Highway 64',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'},
{ Name: 'CVS 9931 Gilead Road', Address: '9931 Gilead Road',CustomerID: '920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{ Name: 'Walgreens',Address: '2805 N Roosevelt Blvd',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'}]

const ids = [{TenantID:1,External_ID:'920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{TenantID:2,External_ID:'FB7BCE3B-E06E-420A-A342-08CF20054F78'}]

const result = source.map(i => {
i.TenantID = ids.find(id => id.External_ID === i.CustomerID).TenantID;
delete i.CustomerID;
return i
}) 

console.log(result)

Keep in mind that while this is probably simple solution, it does mutates your source (deletes CustomerID). Non-mutating version is a bit longer and is not difficult, you can achieve it on your own, if you want.

edited Dec 6, 2018 at 13:36

answered Dec 6, 2018 at 13:31

Nurbol Alpysbayev

22.4k6 gold badges68 silver badges100 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Peter Bode Over a year ago

Array.prototype.map() is indeed the best function! (you where quicker!)

Nurbol Alpysbayev Over a year ago

@PeterBode Yeah, I have the fastest hand in the West)

Alejandro Lariccia · Accepted Answer · 2018-12-06 13:51:25Z

1

try this way:

const array1 = [{ Name: 'CVS 7201 Us Highway 64',Address: '7201 Us Highway 64',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'},
{ Name: 'CVS 9931 Gilead Road', Address: '9931 Gilead Road',CustomerID: '920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{ Name: 'Walgreens',Address: '2805 N Roosevelt Blvd',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'}];

const array2 = [{TenantID:1,External_ID:'920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{TenantID:2,External_ID:'FB7BCE3B-E06E-420A-A342-08CF20054F78'}];

const filteredArray = array1.map(({ Name, Address, CustomerID}) => ({
      Name,
      Address,
      TenantID: array2.reduce((acum, { TenantID, External_ID }) => (External_ID === CustomerID ? TenantID : acum), null)
  }));

console.log(filteredArray);

answered Dec 6, 2018 at 13:51

Alejandro Lariccia

3691 silver badge3 bronze badges

1 Comment

ANJYR Over a year ago

thanks, as per my requirement your solution is perfect.

Akrion · Accepted Answer · 2018-12-08 05:42:37Z

What you could also do since you have a large number of items is to utilize Map and Array.map for a concise and performant solution:

const data = [{ Name: 'CVS 7201 Us Highway 64', Address: '7201 Us Highway 64', CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78' }, { Name: 'CVS 9931 Gilead Road', Address: '9931 Gilead Road', CustomerID: '920FAEF9-826B-4DE6-98F7-07E2201D5020' }, { Name: 'Walgreens', Address: '2805 N Roosevelt Blvd', CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78' } ]
const arr = [{ TenantID: 1, External_ID: '920FAEF9-826B-4DE6-98F7-07E2201D5020' }, { TenantID: 2, External_ID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78' } ]

const map = arr.reduce((r,c) => (r.set(c.External_ID, c.TenantID), r), new Map())

const result = data.map(({Name, Address, CustomerID}) => 
   ({TenantID: map.get(CustomerID), Name, Address}))

console.log(result)

mplungjan · Accepted Answer · 2018-12-06 13:44:31Z

Have a test of this - it is non destructive

const arr1 = [{ Name: 'CVS 7201 Us Highway 64',Address: '7201 Us Highway 64',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'},
{ Name: 'CVS 9931 Gilead Road', Address: '9931 Gilead Road',CustomerID: '920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{ Name: 'Walgreens',Address: '2805 N Roosevelt Blvd',CustomerID: 'FB7BCE3B-E06E-420A-A342-08CF20054F78'}]

const arr2 = [{TenantID:1,External_ID:'920FAEF9-826B-4DE6-98F7-07E2201D5020'},
{TenantID:2,External_ID:'FB7BCE3B-E06E-420A-A342-08CF20054F78'}]

let merged = arr1.map(item => {
  let item2 = arr2.find(itm2 => itm2.External_ID === item.CustomerID);
  if (item2) {
    let newItem = Object.assign({ }, item); 
    newItem.TenantID=item2.TenantID;
    delete newItem.CustomerID; // I am sure there is a way to copy only name and address using { Name, Address } = item
    return newItem;
  }  
});
console.log(merged)
console.log(arr1)

Collectives™ on Stack Overflow

code optimization for multiple array using JavaScript

4 Answers 4

2 Comments

1 Comment

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

2 Comments

1 Comment

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related