JavaScript-Pass values between objects

Question

when I enter at the prompt 0, than I am expecting an alert "stop" but receive "go" instead. Can you help me to get the alert "stop"?

var toyota = {
  make: "Toyota",
  model: "Corolla",
  fuel: 0,
  tank: function(addingfuel) {
    this.fuel = this.fuel + addingfuel;
  },
  start: function() {
    if (this.fuel === 0) {
      alert("stop");
    } else {
      alert("go");
    }
  },
};
var addingfuel = prompt("Please enter fuel added", "liter");
toyota.tank();
toyota.start();

Prompt returns a string. 1, convert to number: +addingfuel; 2. pass it toyota.tank(+addingfuel); — mplungjan
– mplungjan, Commented Dec 9, 2018 at 14:21
The var addingFuel is completely separate from the parameter function(addingFuel). Two completely separate unrelated variables that happen to have the same name. — James
– James, Commented Dec 9, 2018 at 14:25

jame3030 · Accepted Answer · 2018-12-10 17:37:57Z

1

It will work fine if you change this code

this.fuel = this.fuel + addingfuel;

to

  this.fuel = this.fuel + (addingfuel || 0);

answered Dec 10, 2018 at 17:37

jame3030

363 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

dev.waqas · Accepted Answer · 2018-12-09 14:34:06Z

1

You need to change your code a little bit

var toyota = {
  make: "Toyota",
  model: "Corolla",
  fuel: 0,
  tank: function(addingfuel) {
    this.fuel = this.fuel + (addingfuel || 0);
  },
  start: function() {
    if (this.fuel === 0) {
      alert("stop");
    } else {
      alert("go");
    }
  },
};

Explanation When you pass nothing while calling toyota.tank() this will take argument as undefined and append undefined with a number will give you NaN

0 + undefined

answered Dec 9, 2018 at 14:34

dev.waqas

665 bronze badges

Comments

doniyor2109 · Accepted Answer · 2018-12-09 14:30:28Z

0

window. prompt returns string type as a return value. That is why when you adding fuel (number) to addingfuel (string) it results "00" and your condition fails.

In order to overcome this issue, you should cast string to number before working with that value.

tank: function(addingfuel) {
  var numberValue = parseFloat(addingfuel, 10);
  numberValue = isNaN(numberValue) ? 0 : numberValue
  this.fuel = this.fuel + numberValue;
}

answered Dec 9, 2018 at 14:30

doniyor2109

6245 silver badges17 bronze badges

2 Comments

Mister Jojo Over a year ago

this.fuel += numberValue; ;)

doniyor2109 Over a year ago

@MrJ Yea, that is better. Thanks

A l w a y s S u n n y · Accepted Answer · 2018-12-09 14:32:09Z

0

You've to pass the addingfuel with your tank(addingfuel) function other wise addingfuel contains undefined so finally it will show the go instead of stop.

N.B the value of addingfuel is string so you've to cast it to integer like this parseInt(addingfuel) otherwise your this.fuel === 0 condition will fail

Let try this way,

var toyota = {
  make: "Toyota",
  model: "Corolla",
  fuel: 0,
  tank: function(addingfuel) {
    this.fuel = this.fuel + parseInt(addingfuel);
  },
  start: function() {
    if (this.fuel === 0) {
      alert("stop");
    } else {
      alert("go");
    }
  },
};
var addingfuel = prompt("Please enter fuel added", "liter");
toyota.tank(addingfuel); // you need to pass this otherwise it is undefined
toyota.start();

edited Dec 9, 2018 at 14:32

answered Dec 9, 2018 at 14:26

A l w a y s S u n n y

38.8k9 gold badges68 silver badges120 bronze badges

Collectives™ on Stack Overflow

JavaScript-Pass values between objects

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related