Saving Images in SQL using C#

Question

I have a dialog box in a C# Winforms application. I want to save images. But each time I click on the save button, I get an error

A generic error occurred in gdi+

This is my code for saving the image:

var SavedFileName = string.Format(@"{0}.png", Guid.NewGuid());

var path = Application.StartupPath + "/passport/" + SavedFileName.ToString();

if(passportsize.Image == null)
{
    SavedFileName = "";
}
else
{
    passportsize.Image.Save(path,System.Drawing.Imaging.ImageFormat.Png);
}

Unrelated: notice that the .ToString on SavedFileName is redundant since it is already a string. And I would recommend using Path.Combine to construct the file path. Specifically var path = Path.Combine(Application.StartupPath, "passport", SavedFileName);. Are you using Linux or Windows? — Richardissimo
– Richardissimo, Commented Dec 13, 2018 at 21:32
Also, Application.StartupPath is a very bad place to try to save a file; it's probably not writable by non-admins, and will get deleted if you uninstall or repair your application. Save user data in Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData). — Dour High Arch
– Dour High Arch, Commented Dec 14, 2018 at 0:43

Terry Tyson · Accepted Answer · 2018-12-14 14:35:51Z

1

Try using a back slash instead of a forward slash. "\\passport\\" instead of "/passport/"

edited Dec 14, 2018 at 14:35

answered Dec 13, 2018 at 21:36

Terry Tyson

6339 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

ProgrammingLlama Over a year ago

That won't compile.

Hans Keﬆing Over a year ago

You will need to escape the backslashes by doubling them

ProgrammingLlama Over a year ago

@Hans Indeed, I was prompting Terry to do improve the answer.

Terry Tyson Over a year ago

Thanks @John. Getting both of them to show up was a little tricky.

ProgrammingLlama · Accepted Answer · 2018-12-14 05:51:09Z

0

You haven't provided the full message, so I can't be sure, but it's likely that the source stream that created the image has been disposed of but the image is still tied to it.

When you create the image, you should clone it. For example:

private Image ImageFromBytes(byte[] imageBytes)
{
    using (var ms = new MemoryStream(imageBytes))
    {
        using (var image = Image.FromStream(ms))
        {
            return (Image)image.Clone();
        }
    }
}

Then when you come to save it later, you shouldn't encounter any issues.

answered Dec 14, 2018 at 5:51

ProgrammingLlama

39.3k7 gold badges78 silver badges104 bronze badges

Collectives™ on Stack Overflow

Saving Images in SQL using C#

2 Answers 2

4 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related