Django Rest Framework modelviewset - updating fields before create

Question

I have a modelviewset:

class ExpenseViewSet(ModelViewSet):
    permission_classes = [permissions.IsAuthenticated, HasMetis]
    serializer_class = ExpenseSerializer

    def get_queryset(self):
        return Expense.objects.filter(recorded_by=self.request.user)

And a serializer:

class ExpenseSerializer(serializers.ModelSerializer):
    class Meta:
        model = Expense
        fields = ["flat_id", "flat_group_id", "description", "notes", "amount"]

These are the fields that are POSTed to the viewset, but they are not sufficient to populate the object completely, so I need to add some more fields.

I've tried overriding the serializer, like so:

class ExpenseSerializer(serializers.ModelSerializer):
    class Meta:
        model = Expense
        fields = ["flat_id", "flat_group_id", "description", "notes", "amount"]

    def create(self, validated_data):
        expense = Expense.objects.create(
            flat_id=validated_data["operations_flat"],
            flat_group_id=validated_data["operations_building"],
            description=validated_data["description"],
            notes=validated_data["notes"],
            amount=validated_data["amount"],
            recorded_by=self.request.user,
        )
        return expense

This, however, is never called (tested by sticking a print statement in the create function - it never runs). Apparently this is because of this question: Django Rest Framework serializer create() doesn't get triggered This explains the issue, but not how to solve my problem.

I'm not sure whether I need to override the is_valid function of the serializer, the create function of the serializer, or the create function of the viewset, or something else.

Might be you overrode something on the viewset that messes the default views behavior or the data you provided aren't valid (check the server response code and content). — Linovia
– Linovia, Commented Dec 17, 2018 at 22:56

Umair Mohammad · Accepted Answer · 2018-12-18 05:09:58Z

2

You should override the perform_create() on viewset something like this and pass in your extra data for object creation:

def perform_create(self, serializer):
    serializer.save(user=self.request.user)

Reference : Save and deletion hooks: https://www.django-rest-framework.org/api-guide/generic-views/#genericapiview (search perform_create in this page for faster lookup)

answered Dec 18, 2018 at 5:09

Umair Mohammad

4,6432 gold badges22 silver badges35 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

NeonCop Over a year ago

clutch!!! was looking for this for a while

Collectives™ on Stack Overflow

Django Rest Framework modelviewset - updating fields before create

1 Answer 1

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related