Adding a class to an array list

Question

I am currently coding an RPG using java classes as a side project after completing my OODP course. I have 3 classes which this problem is concerned with. A Job class, a Knight Class and a Skills Class. Knight inherits the properties from the Job class and has a "has a" relationship with the Skills class. The code snippet of Knight Class is shown below. My issue is that the second last line, skills.add(slash); is getting multiple errors. I tested with just an array list of Integers to add Integers to the array list resulting in the same set of errors. Is there something wrong with my code or syntax here?

import java.util.ArrayList;

public class Knight extends Job {
    public Knight() {
        super("Knight");
    }

    private ArrayList<Skills> skills = new ArrayList<Skills>();
    Skills slash = new Skills(5, 1, "Slash");
    skills.add(slash);
}

This is the constructor for the Skills class

public Skills(int dps, int mana, String name) {
    this.dps=dps;
    this.mana=mana;
    this.name=name;
}

These are the errors I have encountered

Multiple markers at this line
- Syntax error, insert ")" to complete MethodDeclaration
- Syntax error, insert "SimpleName" to complete 
 QualifiedName
- Syntax error on token ".", @ expected after this token
- Syntax error, insert "Identifier (" to complete 
 MethodHeaderName

You aren't in a method, constructor or initialization block. You are currently defining another class field named slash with package private access. I suspect you wanted to put skills.add(new Skills(5,1,"Slash")); in your constructor. — Elliott Frisch
– Elliott Frisch, Commented Jan 7, 2019 at 4:08
Put these lines private ArrayList<Skills> skills= new ArrayList<Skills>(); Skills slash= new Skills(5,1,"Slash"); skills.add(slash); in a method/initialization block/constructor. — Nicholas K
– Nicholas K, Commented Jan 7, 2019 at 4:09
omg I am not in a method and this is not a main class..... Thanks, I must be tired haha — Mark Nicholas Heah
– Mark Nicholas Heah, Commented Jan 7, 2019 at 4:09
Please read error messages carefully. It tells you have a syntax error with the specified identifiers. You can also read about how Java compiler works. — Adam
– Adam, Commented Jan 7, 2019 at 7:24

talex · Accepted Answer · 2019-01-07 04:10:21Z

1

You can't have statement directly inside class. You have to put it in constructor, method or initializer.

In your case just put skills.add(slash); in constructor.

answered Jan 7, 2019 at 4:10

talex

20.8k3 gold badges34 silver badges71 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Teja Venkat Lanka · Accepted Answer · 2019-01-07 04:17:56Z

1

change the your knight code as follow

 import java.util.ArrayList;
 private ArrayList<Skills> skills = new ArrayList<Skills>();
 Skills slash = new Skills(5, 1, "Slash");
    public class Knight extends Job {
    public Knight() {
        super("Knight");
    skills.add(slash);
    }

}

if you want to add more skill on run time, write one method to.

answered Jan 7, 2019 at 4:17

Teja Venkat Lanka

389 bronze badges

Comments

Sandeepa · Accepted Answer · 2019-01-07 04:59:14Z

1

private ArrayList<Skills> skills = new ArrayList<Skills>();
Skills slash = new Skills(5, 1, "Slash");
skills.add(slash);

Above part or at least skills.add(slash); should be inside one of the following,

Inside a method
Inside the main method
Inside a constructor
Inside an instance initializer block or in a static initializer block

edited Jan 7, 2019 at 4:59

answered Jan 7, 2019 at 4:20

Sandeepa

3,7805 gold badges32 silver badges45 bronze badges

2 Comments

Santosh Over a year ago

Not all three, only skills.add(slash); should be in the method, constructor or static block. Other two declarations can be inside class.

Sandeepa Over a year ago

@Santosh Edited it.

prachi · Accepted Answer · 2019-01-07 06:02:59Z

1

You have not put "skills.add(slash)" statement inside a method/constructor/initializer , this is why you are getting error. Simply change the code to -

   import java.util.ArrayList;

    public class Knight extends Job {
         private ArrayList<Skills> skills = new ArrayList<Skills>();
         Skills slash = new Skills(5, 1, "Slash");
         public Knight() {
             super("Knight");
             skills.add(slash);
         } 

     }

answered Jan 7, 2019 at 6:02

prachi

3051 silver badge7 bronze badges

Collectives™ on Stack Overflow

Adding a class to an array list

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

2 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related