How to check if string (current URL) includes a few substrings

Question

I need to check if current URL includes a few substrings. My code works but I need a tip if it possible to make it better. I realize that duplicating code is not a good practice. I am working with Angular 6/Typescript/ECMAScript 6.

const currentUrl = this.location.path();
const displayTile = currentUrl.includes('/search-resources') || currentUrl.includes('/calendar') || currentUrl.includes('/yearbooks')? 1 : 2;

Ashish Ranjan · Accepted Answer · 2019-01-09 11:07:50Z

2

Your code is just fine, if you want to reduce the length of checks, have the substrings in an array. like:

var substrings = ['/search-resources', '/calendar', '/yearbooks']

Test your condition using:

const displayTile = substrings.some((e) => currentUrl.includes(e)) ? 1 : 2

Array.some()

The some() method tests whether at least one element in the array passes the test implemented by the provided function.

edited Jan 9, 2019 at 11:07

answered Jan 9, 2019 at 10:58

Ashish Ranjan

13k5 gold badges32 silver badges53 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Ashish Ranjan Over a year ago

@NataliaGurgul: Please consider accepting answers if they solve your question.

Abdul Basit · Accepted Answer · 2019-01-09 10:58:54Z

0

jQuery has $.inArray

var names = ['search-resources', 'calendar'];
if ($.inArray('calendar', names) !== -1) {
    // do stuff
}

edited Jan 9, 2019 at 10:58

answered Jan 9, 2019 at 10:52

Abdul Basit

1,3801 gold badge10 silver badges18 bronze badges

2 Comments

Natalia Gurgul Over a year ago

I don't use jQuery

Abdul Basit Over a year ago

@NataliaGurgul you can check this link for your better answer frontstuff.io/…

Collectives™ on Stack Overflow

How to check if string (current URL) includes a few substrings

2 Answers 2

1 Comment

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related