Listbox not sorting in WPF application

Question

I'm attempting to re-sort my list when adding/removing from it by storing to a list and then sorting it. When I run my application, the new items added to the list are always added to the bottom instead of sorted.

FileCabinetsRetreived is my first ListBox and FileCabinetsToAdd is my second list box.

    private void addBttn_Click(object sender, RoutedEventArgs e)
    {
        List<string> allItems = new List<string>();
        List<string> addedItems = new List<string>();
        List<string> remainingItems = new List<string>();

        //adding all items in FileCabinetsretreived into allItems list
        foreach (var item in FileCabinetsRetrieved.Items)
        {
            allItems.Add(item.ToString());
        }

        //sorting all items list
        allItems = allItems.OrderBy(x => x).ToList();

        //adding Selected items to addedItems list
        foreach (var item in FileCabinetsRetrieved.SelectedItems)
        {
            addedItems.Add(item.ToString());
        }

        //sorting addedItems list
        addedItems = addedItems.OrderBy(x => x).ToList();

        // creating list of remaining items = allitems - addedItems
        remainingItems = allItems.Except(addedItems).ToList();

        //sorting remainingItems list
        remainingItems = remainingItems.OrderBy(x => x).ToList();

        //adding list of selected items to the FileCabinetsToAdd list
        foreach (var item in addedItems)
        {
                FileCabinetsToAdd.Items.Add(item);
        }

        //clearing FileCabinetsRetreived list
        FileCabinetsRetrieved.Items.Clear();

        //adding remainingItems list to FileCabinetsRetreived list
        foreach (var item in remainingItems)
        {
            FileCabinetsRetrieved.Items.Add(item.ToString());
        }

    }

I've readed your code but I'm not completely sure about what are you trying to accomplish. Maybe a UI picture could help me to understand your problem. Just a heads up: you are not sorting FileCabnetsToAdd.Items in your code (in order to do so, you'll need to do something like you are doing with FileCabinetsRetrieved) — Guillermo Gerard
– Guillermo Gerard, Commented Jan 16, 2019 at 21:00
Imaged added. The listbox on the right is not adding items in alphabetical order, which is what the method should be doing — Tom D
– Tom D, Commented Jan 16, 2019 at 22:35

Guillermo Gerard · Accepted Answer · 2019-01-16 23:41:01Z

1

Ok, you should sort the Items of the FileCabinetsToAdd Listbox. To do so, you can use the sort property of the listbox:

FileCabinetsToAdd.Sorted = true;

That line should do the work.

If you need a custom sorting, then you should:

back up the items in a list
clear the entire FileCabinetsToAdd.Items collection
add the new items to that list
sort the list
add every item in the list to the FileCabinetsToAdd.Items

edited Jan 16, 2019 at 23:41

answered Jan 16, 2019 at 22:49

Guillermo Gerard

92210 silver badges22 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Tom D Over a year ago

Issue was that I wasn't updating the 2nd listbox the same way. I ended up rewriting the whole method

profgyuri · Accepted Answer · 2019-01-17 12:45:57Z

1

This would be my Add_button click event, although i did not run it so may have some errors, but it's a good start.

List<string> toSort = new List<string>();    

foreach (var item in FileCabinetsRetrieved.SelectedItems)
        {
            FileCabinetsRetrieved.Items.Remove(item);
            toSort.Add(item);
        }
foreach (var item in FileCabinetsToAdd.Items)
        {
            toSort.Add(item);
        }

toSort = toSort.OrderBy(x => x).ToList();
FileCabinetsToAdd.Items.Clear();
foreach (var item in toSort)
{
    FileCabinetsToAdd.Items.Add(item);
}

The important part is clearing the list and then adding all the sorted items again.

edited Jan 17, 2019 at 12:45

answered Jan 17, 2019 at 0:53

profgyuri

10311 bronze badges

Collectives™ on Stack Overflow

Listbox not sorting in WPF application

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related