preg_replace with callback not replacing?

Question

I have this function to replace a text with an url to url link. The callback is used to check if it has http or not in the link, if it has not, add http on it:

<?php

function toLink($titulo){
    $url = '~(?:(https?)://([^\s<]+)|(www\.[^\s<]+?\.[^\s<]+))(?<![\.,:])~i'; 

    $titulo = preg_replace_callback($url, function($matches) {
        $url = $matches[0];
        if (!preg_match('/^https?:\/\//', $url)) {
            $url = 'http://'.$matches[0];
            $url = '<a href="'.$url.'" target="_blank" 
                       title="'.$url.'">'.$url.'</a>';
        }
    },$titulo);


    return $titulo;
}


echo toLink("hi from www.google.com");

The return value is hi from where is my link?

I haven't really looked at the regex, but shouldn't the callback return something? — Don't Panic
– Don't Panic, Commented Jan 18, 2019 at 17:01
At the end of the callback (function($matches) { ... }), after you've created the URL you want, return it — Don't Panic
– Don't Panic, Commented Jan 18, 2019 at 17:05
@sal I really thought this must have been a duplicate, because it seems like such an easy mistake to make, but I haven't been able to find one. Your answer is fine, no need to add another one IMO, but thanks anyway. — Don't Panic
– Don't Panic, Commented Jan 18, 2019 at 17:27

Jnt0r · Accepted Answer · 2019-01-18 17:10:10Z

1

Your callback needs to return the string (or value) that should be inserted. This gives you more information.

answered Jan 18, 2019 at 17:10

Jnt0r

1733 silver badges17 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

sal · Accepted Answer · 2019-01-18 17:18:33Z

As mentioned in the comments, the callback function must return a value, to make this fully work. To tie things together, you just need a return $url statement in the end of the callback, like this:

function toLink($titulo){
    $url = '~(?:(https?)://([^\s<]+)|(www\.[^\s<]+?\.[^\s<]+))(?<![\.,:])~i'; 

    $titulo = preg_replace_callback($url, function($matches) {
        $url = $matches[0];
        if (!preg_match('/^https?:\/\//', $url)) {
            $url = 'http://'.$matches[0];
            $url = '<a href="'.$url.'" target="_blank" 
                       title="'.$url.'">'.$url.'</a>';
        }
        return $url;    // <---- return the $url
    },$titulo);


    return $titulo;
}


echo toLink("hi from www.google.com");

Check the result on https://eval.in/1079110

Collectives™ on Stack Overflow

preg_replace with callback not replacing?

2 Answers 2

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related