What is wrong with this JavaScript code?

Question

I have two checkboxes name check1 and check2. I wanted for either one to be disabled if the other one was checked. This is what I did:

var male = document.getElementById("check1");
var female = document.getElementById("check2");

male.disabled = (female.checked == true) ? true : false;
female.disabled = (male.checked == true) ? true : false;

It does not work at all. Is the syntax correct. What did I do wrong?

You can check for javascript syntax errors with : jslint.com. It has a slight learning curve but its extremely useful. — James Hulse
– James Hulse, Commented Mar 25, 2011 at 0:55
Consider using radio buttons instead of checkboxes. The user is likely to be less confused by radio buttons behaving normally than by checkboxes behaving like radio buttons. — Guffa
– Guffa, Commented Mar 25, 2011 at 1:06
@J-P, part of his question was whether his syntax is correct. jslint can confirm that it is. It doesn't answer his question so thats why I only put it as a comment. — James Hulse
– James Hulse, Commented Mar 25, 2011 at 1:58

alex · Accepted Answer · 2011-03-25 00:56:58Z

2

You need the onchange event, and your code could be tidied up as well.

var male = document.getElementById("check1"),
    female = document.getElementById("check2");

male.onchange = function() {
    female.disabled = male.checked;
};

female.onchange = function() {
    male.disabled = female.checked;
};

jsFiddle.

Also, shouldn't you be using radio input?

answered Mar 25, 2011 at 0:56

alex

492k205 gold badges890 silver badges992 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Billy Moon Over a year ago

You need to remove extra closing brackets after functions. Here is a working example uses jquery: jsfiddle.net/billymoon/wAukf

meder omuraliev · Accepted Answer · 2011-03-25 00:53:59Z

0

disabled shouldn't be set at all in order to be disabled AFAIK, any value is "truthy"

do .removeAttribute('disabled') to not have it disabled.

answered Mar 25, 2011 at 0:53

meder omuraliev

187k76 gold badges401 silver badges443 bronze badges

Comments

Valerij · Accepted Answer · 2011-03-25 00:54:26Z

0

you need to change the state of the other checkbox when one is clicked eg. male changed - alter female, and versa verse.

function maleOnClick(){
    female.checked= !this.checked;
}
function femaleOnClick(){
    male.checked= !this.checked;
}

Anyway why dont you use type="radio"

answered Mar 25, 2011 at 0:54

Valerij

27.9k1 gold badge30 silver badges43 bronze badges

Comments

Diodeus - James MacFarlane · Accepted Answer · 2011-03-25 00:55:38Z

0

Try:

 male.setAttribute('disabled', 'disabled'); //set
 male.setAttribute('disabled', ''); //clear

So:

male.setAttribute = (female.checked == true) ? 'disabled': '';

answered Mar 25, 2011 at 0:55

Diodeus - James MacFarlane

115k33 gold badges164 silver badges180 bronze badges

Collectives™ on Stack Overflow

What is wrong with this JavaScript code?

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related