PHP foreach issue with jQuery

Question

I have a foreach loop which loops and shows all the data in an array without a problem, however I have some jQuery I want applying to the results, but the jQuery only works on the first piece of data to be displayed. I am not really sure why, if anyone could help that would be great.

$count_limit = 0;
$limit = 5;

foreach ( $feeds->data as $item ) {
extract( (array) $item );
if($count_limit++  < $limit){
?>
<div id="news_post">
    <? $title_str = str_replace('–', '&#150;', $title) ?>
    <p class="news_title"><a href="<?php echo $link; ?>" target="_blank"><?php echo $title_str; ?></a> <a href="#" class="read">read...</a></p>
    <div class="news_desc"><?php echo "$description" ?></div>
</div>
<? }
else {
    break;
}


$(this).next('.news_desc').hide();
        $(this).next('a.read').click(function() {
            $(this).next('.news_desc').toggle();
        });

Can we see the JQuery script?

Chris Sobolewski
– Chris Sobolewski

2011-03-25 01:27:42 +00:00
Commented Mar 25, 2011 at 1:27 — Chris Sobolewski
– Chris Sobolewski, Commented Mar 25, 2011 at 1:27
<a href="<?php echo $link; ?>" *facepalm

Travis Webb
– Travis Webb

2011-03-25 01:30:27 +00:00
Commented Mar 25, 2011 at 1:30 — Travis Webb
– Travis Webb, Commented Mar 25, 2011 at 1:30

Martin Tournoij · Accepted Answer · 2011-03-25 01:48:27Z

2

You forgot to post the jQuery you're using :-) But I suspect it's because all the divs you use have the same id ("news_post") so jQuery only uses the first id it finds.

You can postfix the id with $count_limit to make a truly unique id (HTML specs don't allow multiple elements with the same id attribute either) or change the way jQuery selects the elements to operate on (For example by classname).

EDIT: It's been a while since I used jQuery but this looks odd, why not just use:

$(.news_desc').hide();
$('a.read').click(function() {
  $(this).next('.news_desc').toggle();
});

edited Mar 25, 2011 at 1:48

answered Mar 25, 2011 at 1:26

Martin Tournoij

28k24 gold badges110 silver badges158 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Lit Over a year ago

I have added the jQuery to the bottom of the post, so it is looping through the foreach and only applying the jQuery the first time if finds the classes?

Martin Tournoij Over a year ago

No, I meant div#news_post, but that's not relevant ... Comment about having multiple elements with the same id attribute is still valid though. The whole point of the id attribute is to have a unique identifier for an element.

Lit Over a year ago

I have fixed the issue, I placed $(this).next('.news_desc').toggle(); into the jQuery

Mlynch1985 · Accepted Answer · 2011-03-25 02:58:40Z

0

So I would move the jQuery outside of the loop and I would hide each post by default with exception of the first.

$('.news_desc').not(':first').hide();

Then I would add a click even that will hide all except for the one selected.

$('a.read').click(function() {
     $('.news_desc').not(this).hide();
}

Not 100% sure this will work as it has been a while since I've used jQuery, but I assume you are looking to show only the post titles and have only 1 post description in view at a time.

answered Mar 25, 2011 at 2:58

Mlynch1985

761 gold badge1 silver badge5 bronze badges

Collectives™ on Stack Overflow

PHP foreach issue with jQuery

2 Answers 2

3 Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related